Summary: | Setting document.title when there is no title and no head element should no nothing | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||
Component: | DOM | Assignee: | Chris Dumez <cdumez> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap, commit-queue, esprehn+autocc, kangil.han, rniwa, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar, WebExposed | ||||
Version: | Other | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
URL: | https://html.spec.whatwg.org/multipage/dom.html#document.title | ||||||
Attachments: |
|
Description
Chris Dumez
2015-09-09 10:59:20 PDT
Created attachment 260865 [details]
Patch
Comment on attachment 260865 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=260865&action=review > Source/WebCore/dom/Document.cpp:1541 > + m_titleElement = createElement(titleTag, false); This boolean argument sucks :( We should replace it with enum class in the future. Comment on attachment 260865 [details] Patch Clearing flags on attachment: 260865 Committed r189555: <http://trac.webkit.org/changeset/189555> All reviewed patches have been landed. Closing bug. |