Bug 149004

Summary:

SVG transforming path crashes Safari

Product:

WebKit

Reporter:

Luis Merino <mail>

Component:

SVG

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED WORKSFORME

Severity:

Normal

CC:

ap, zimmermann

Priority:

Version:

Safari 8

Hardware:

Mac

OS:

OS X 10.10

Attachments:

Description	Flags
Crash report	none
Icon with padding-right: 30px causing the WebContent crash.	none

Description Luis Merino 2015-09-09 09:39:33 PDT

On multiple occasions, some pages from the same site crash completely the app.

- Try https://www.nestpick.com/barcelona/great-room-in-a-4-bedroom-flat-near-urgell-station-21183.html?s_page=15&s__pjax=.results&s_special=all&s_dir=desc to see the crash.

- This other apartment (same layout) does not crash Safari: https://www.nestpick.com/madrid/beautiful-room-in-a-4-bedroom-flat-near-embajadores-station-11063.html?s_special=all&s_dir=desc

This bug started happening when I updated to Safari 8.0.8 (10600.8.9). Yesterday I was running 8.0.7 (100600.7.10) completely without problems. The new version introduced the bug.

No other browser afaik is causing problems on this. Please see the attachment for a full stack trace of the Crash report.

Comment 1 Luis Merino 2015-09-09 15:45:52 PDT

Created attachment 260883 [details]
Crash report

Comment 2 Alexey Proskuryakov 2015-09-09 23:10:27 PDT

I cannot reproduce this in Safari 8.0.8, the page doesn't cause a crash.

Looking at the crash report, this looks like something that is already fixed. Could you please try to reproduce with a WebKit nightly, or with El Capitan public beta?

WebKit nightly builds can be downloaded from <http://nightly.webkit.org>, and don't modify your OS installation when used.

Comment 3 Luis Merino 2015-09-10 00:43:55 PDT

So, it's not 100% of the times replayable, safest is to close the process completely and reopen WebContent on that page. For me it fails consistently. Not just me but everyone in the office with 8.0.8 installed.

I can confirm this has already been fixed in the nightly built, this is good news.

However, at the moment this doesn't help us, I will keep digging because there's an obvious bug here on something we're using. I'm thinking our use of SVG and USE tags, somehow it's ending execution. I'll post my findings asap.

Regards,

Comment 4 Alexey Proskuryakov 2015-09-10 09:44:03 PDT

Thank you for the confirmation! Closing as WORKSFORME, as this is fixed in WebKit already.

I understand that this is still causing problems, and a workaround would help. This crash is likely due to bug 143903, or possibly another similar bug that was fixed earlier. So I would suggest avoiding non-invertible transforms in your SVG content.

Comment 5 Luis Merino 2015-09-11 02:03:23 PDT

Created attachment 260997 [details]
Icon with padding-right: 30px causing the WebContent crash.

@Alexey found the offending part; one of our SVG icons has a padding-right:30px; rule applied (see attachment). I've opted for using margin-right instead, although changing 30px to 1px stopped the crashing (no further research). So CSS padding influences in the subpixel calculation of the transforming path by the SVG library, according to the related ticket below. It escapes out of my knowledge the exact reasons beyond, I do not have the background to understand it. I'm leaving this comment here to extend on this, as a possible solution for others who find a similar crash on 8.0.8 (10600.8.9). Thanks for you attention.