Bug 148983

Summary:

Refactor the test for the arithmetic instructions in WebAssembly

Product:

WebKit

Reporter:

Sukolsak Sakshuwong <sukolsak>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	mark.lam: review+, commit-queue: commit-queue-
Update to ToT	none

Sukolsak Sakshuwong

Reported 2015-09-08 15:43:56 PDT

Pass the values into the test functions as per Mark's suggestion in https://bugs.webkit.org/show_bug.cgi?id=148882#c3

Attachments
Patch (13.31 KB, patch) 2015-09-08 15:48 PDT, Sukolsak Sakshuwong	mark.lam: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
Update to ToT (13.26 KB, patch) 2015-09-08 17:39 PDT, Sukolsak Sakshuwong	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Sukolsak Sakshuwong

Comment 1 2015-09-08 15:48:29 PDT

Created attachment 260800 [details] Patch

Mark Lam

Comment 2 2015-09-08 15:52:52 PDT

Comment on attachment 260800 [details] Patch r=me

WebKit Commit Bot

Comment 3 2015-09-08 16:16:32 PDT

Comment on attachment 260800 [details] Patch Rejecting attachment 260800 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 260800, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: /git.webkit.org/WebKit de742a2..4e438a2 master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 189514 = de742a28d5f85caad245ee0624ba945ad52bbd80 r189515 = 4e438a2d262b9dd25ca2770d88f25a67c67ea3d0 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.webkit.org/results/152144

Sukolsak Sakshuwong

Comment 4 2015-09-08 17:39:10 PDT

Created attachment 260819 [details] Update to ToT

Yusuke Suzuki

Comment 5 2015-09-08 20:32:20 PDT

Comment on attachment 260819 [details] Update to ToT r=me

WebKit Commit Bot

Comment 6 2015-09-08 21:19:11 PDT

Comment on attachment 260819 [details] Update to ToT Clearing flags on attachment: 260819 Committed r189532: <http://trac.webkit.org/changeset/189532>

WebKit Commit Bot

Comment 7 2015-09-08 21:19:14 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.