Bug 148973

Summary: new Comment(undefined) / new Text(undefined) should use default's empty string
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, buildbot, commit-queue, ggaren, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar, WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews103 for mac-mavericks
none
Patch none

Chris Dumez
Reported 2015-09-08 11:29:55 PDT
new Comment(undefined) / new Text(undefined) should use default's empty string instead of converting undefined to the "undefined" string: https://dom.spec.whatwg.org/#interface-comment (parameter is optional, default value is empty String) https://dom.spec.whatwg.org/#text (ditto) undefined should be treated as if the parameter is missing, in the case the parameter is optional, as per the Web IDL specification.
Attachments
Patch (15.44 KB, patch)
2015-09-08 11:49 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews103 for mac-mavericks (701.71 KB, application/zip)
2015-09-08 12:14 PDT, Build Bot 		no flags
Details
Patch (17.58 KB, patch)
2015-09-08 12:23 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2015-09-08 11:30:23 PDT
rdar://problem/22548042
Chris Dumez
Comment 2 2015-09-08 11:49:59 PDT
Created attachment 260777 [details] Patch
Build Bot
Comment 3 2015-09-08 12:14:55 PDT
Comment on attachment 260777 [details] Patch Attachment 260777 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/151594 New failing tests: js/dom/custom-constructors.html
Build Bot
Comment 4 2015-09-08 12:14:58 PDT
Created attachment 260780 [details] Archive of layout-test-results from ews103 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-mavericks Platform: Mac OS X 10.9.5
Chris Dumez
Comment 5 2015-09-08 12:23:15 PDT
Created attachment 260781 [details] Patch
WebKit Commit Bot
Comment 6 2015-09-08 14:57:30 PDT
Comment on attachment 260781 [details] Patch Clearing flags on attachment: 260781 Committed r189507: <http://trac.webkit.org/changeset/189507>
WebKit Commit Bot
Comment 7 2015-09-08 14:57:35 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.