new Comment(undefined) / new Text(undefined) should use default's empty string

• Component: DOM
• Status: RESOLVED FIXED

[Chris Dumez]

new Comment(undefined) / new Text(undefined) should use default's empty string instead of converting undefined to the "undefined" string:
https://dom.spec.whatwg.org/#interface-comment (parameter is optional, default value is empty String)
https://dom.spec.whatwg.org/#text (ditto)

undefined should be treated as if the parameter is missing, in the case the parameter is optional, as per the Web IDL specification.

[Chris Dumez]

rdar://problem/22548042

[Chris Dumez]

Created attachment 260777 [details]
Patch

[Build Bot]

Comment on attachment 260777 [details]
Patch

Attachment 260777 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/151594

New failing tests:
js/dom/custom-constructors.html

[Build Bot]

Created attachment 260780 [details]
Archive of layout-test-results from ews103 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Chris Dumez]

Created attachment 260781 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 260781 [details]
Patch

Clearing flags on attachment: 260781

Committed r189507: <http://trac.webkit.org/changeset/189507>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.