Bug 148938

Summary:

[GTK] 15 accessibility tests fail since r186692.

Product:

WebKit

Reporter:

Carlos Alberto Lopez Perez <clopez>

Component:

WebKitGTK

Assignee:

Joanmarie Diggs <jdiggs>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, jcraig, jdiggs, mario, n_wang, samuel_white

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

146887

Attachments:

Description	Flags
Patch	none

Description Carlos Alberto Lopez Perez 2015-09-07 11:47:23 PDT

Since r186692 <http://trac.webkit.org/r186692> the following tests fail on the GTK port.

Regressions: Unexpected text-only failures (15)
  accessibility/aria-table-hierarchy.html [ Failure ]
  accessibility/aria-table-with-presentational-elements.html [ Failure ]
  accessibility/aria-tables.html [ Failure ]
  accessibility/poorly-formed-aria-table.html [ Failure ]
  accessibility/roles-computedRoleString.html [ Failure ]
  accessibility/roles-exposed.html [ Failure ]
  accessibility/table-attributes.html [ Failure ]
  accessibility/table-cell-spans.html [ Failure ]
  accessibility/table-cells.html [ Failure ]
  accessibility/table-detection.html [ Failure ]
  accessibility/table-fallback-roles-expose-element-attributes.html [ Failure ]
  accessibility/table-sections.html [ Failure ]
  accessibility/table-with-footer-section-above-body.html [ Failure ]
  accessibility/table-with-missing-aria-role-rows.html [ Failure ]
  accessibility/table-with-rules.html [ Failure ]


I have tested to locally revert r186692 and the 15 tests pass after that.

I guess something is missing to be implemented on the GTK port, or the tests need a rebaseline.
I'm not familiar with the accessibility code, so I'm just opening the bug and marking this tests as failing on the GTK TestExpectation file.

The links to the diffs are:

https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20%28Tests%29/r189464%20%2810899%29/accessibility/table-sections-pretty-diff.html
https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20%28Tests%29/r189464%20%2810899%29/accessibility/roles-computedRoleString-pretty-diff.html
https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20%28Tests%29/r189464%20%2810899%29/accessibility/table-detection-pretty-diff.html
https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20%28Tests%29/r189464%20%2810899%29/accessibility/table-with-missing-aria-role-rows-pretty-diff.html
https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20%28Tests%29/r189464%20%2810899%29/accessibility/roles-exposed-pretty-diff.html
https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20%28Tests%29/r189464%20%2810899%29/accessibility/table-with-footer-section-above-body-pretty-diff.html
https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20%28Tests%29/r189464%20%2810899%29/accessibility/aria-table-with-presentational-elements-pretty-diff.html
https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20%28Tests%29/r189464%20%2810899%29/accessibility/poorly-formed-aria-table-pretty-diff.html
https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20%28Tests%29/r189464%20%2810899%29/accessibility/table-with-rules-pretty-diff.html
https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20%28Tests%29/r189464%20%2810899%29/accessibility/table-fallback-roles-expose-element-attributes-pretty-diff.html
https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20%28Tests%29/r189464%20%2810899%29/accessibility/aria-table-hierarchy-pretty-diff.html
https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20%28Tests%29/r189464%20%2810899%29/accessibility/aria-tables-pretty-diff.html
https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20%28Tests%29/r189464%20%2810899%29/accessibility/table-attributes-pretty-diff.html
https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20%28Tests%29/r189464%20%2810899%29/accessibility/table-cell-spans-pretty-diff.html
https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20%28Tests%29/r189464%20%2810899%29/accessibility/table-cells-pretty-diff.html

Comment 1 Joanmarie Diggs 2015-12-08 02:13:24 PST

Created attachment 266864 [details]
Patch

Comment 2 Mario Sanchez Prada 2015-12-08 02:19:33 PST

Comment on attachment 266864 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=266864&action=review

Looks good, just a minor comment below to consider before landing

> Source/WebCore/ChangeLog:8
> +        Failing tests rebaselined.

It looks like this comment belongs to LayoutTests/ChangeLog and something else should be in here

Comment 3 WebKit Commit Bot 2015-12-08 03:07:30 PST

Comment on attachment 266864 [details]
Patch

Clearing flags on attachment: 266864

Committed r193746: <http://trac.webkit.org/changeset/193746>

Comment 4 WebKit Commit Bot 2015-12-08 03:07:33 PST

All reviewed patches have been landed.  Closing bug.