Bug 148920

Summary:

Dashboard: Remove duplicate gear icon data URLs

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

Tools / Tests

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aestes, ap, timothy

Priority:

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Description Daniel Bates 2015-09-06 21:05:04 PDT

Currently we duplicate the SVG data URL for the gear icon (shown in the top left of the dashboard) up to its fill color for each of its three states: collapsed, hover, and expanded. We can simplify the CSS selectors for the gear icon by treating the gear icon as a mask using -webkit-mask-image and specifying the appropriate fill color using the CSS property background-color.

Comment 1 Daniel Bates 2015-09-06 21:06:33 PDT

Created attachment 260728 [details]
Patch

Comment 2 Daniel Bates 2015-09-08 08:58:04 PDT

Comment on attachment 260728 [details]
Patch

Clearing flags on attachment: 260728

Committed r189488: <http://trac.webkit.org/changeset/189488>

Comment 3 Daniel Bates 2015-09-08 08:58:09 PDT

All reviewed patches have been landed.  Closing bug.