| Summary: | [WK2][GTK][GStreamer] Build fails when -plugins-base and -core headers are not installed in same directory | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | 宋文武 <iyzsong> | ||||||
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cgarcia, hhochleitner, pnormand | ||||||
| Priority: | P2 | ||||||||
| Version: | Other | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Linux | ||||||||
| Attachments: |
|
||||||||
Is this issue still valid? Assuming this bug can be closed, no follow-up feedback from the bug reporter and the build bots have no such issue either. Please reopen if any change is really needed :) This is still a problem with 2.14 see https://github.com/NixOS/nixpkgs/blob/b137b8d1aa14637db1397aaffacf0524d95803e6/pkgs/development/libraries/webkitgtk/2.14.nix#L44 for our current workaround when removing it, i got [ 95%] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/API/gtk/PageClientImpl.cpp.o In file included from /tmp/nix-build-webkitgtk-2.14.2.drv-0/webkitgtk-2.14.2/build/DerivedSources/ForwardingHeaders/WebCore/GUniquePtrGStreamer.h:1:0, from /tmp/nix-build-webkitgtk-2.14.2.drv-0/webkitgtk-2.14.2/Source/WebKit2/UIProcess/gstreamer/InstallMissingMediaPluginsPermissionRequest.h:30, from /tmp/nix-build-webkitgtk-2.14.2.drv-0/webkitgtk-2.14.2/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewPrivate.h:30, from /tmp/nix-build-webkitgtk-2.14.2.drv-0/webkitgtk-2.14.2/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp:41: /tmp/nix-build-webkitgtk-2.14.2.drv-0/webkitgtk-2.14.2/Source/WebCore/platform/graphics/gstreamer/GUniquePtrGStreamer.h:25:41: fatal error: gst/pbutils/install-plugins.h: No such file or directory compilation terminated. make[2]: *** [Source/WebKit2/CMakeFiles/WebKit2.dir/build.make:12932: Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/API/gtk/PageClientImpl.cpp.o] Error 1 make[1]: *** [CMakeFiles/Makefile2:1534: Source/WebKit2/CMakeFiles/WebKit2.dir/all] Error 2 make: *** [Makefile:150: all] Error 2 builder for ‘/nix/store/b0i8cbyxczybnnibb93l0jv7ma6k5f09-webkitgtk-2.14.2.drv’ failed with exit code 2 Thanks, this should be easy to fix. Please test the patch I'm about to upload here. Created attachment 293877 [details]
patch
Created attachment 293878 [details]
patch
Thanks, I'm running a build with patch 293878 (sans ChangeLog update, which doesn't apply against 2.14.2) Will report back, when it finishes ... Build of 2.14.2 + patch finished successfully. Thanks! Comment on attachment 293878 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=293878&action=review I'm confused. I have no idea what pbutils is, but the bug title refers to GSTREAMER_BASE_INCLUDE_DIRS and WebKit2_INCLUDE_DIRECTORIES and the patch includes GSTREAMER_PBUTILS_INCLUDE_DIRS in WebKit2_SYSTEM_INCLUDE_DIRECTORIES > Source/WebKit2/ChangeLog:9 > + * PlatformGTK.cmake: The GStreamer pbutils include directory was > + missing in the header search path. Could you explain here what is broken? do we fail to build with any build config? Committed r208528: <http://trac.webkit.org/changeset/208528> |
otherwise, failed with: ... [ 91%] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/WebPageProxy.cpp.o In file included from /tmp/nix-build-webkitgtk-2.8.5.drv-0/webkitgtk-2.8.5/build/DerivedSources/ForwardingHeaders/WebCore/GUniquePtrGStreamer.h:1:0, from /tmp/nix-build-webkitgtk-2.8.5.drv-0/webkitgtk-2.8.5/Source/WebKit2/UIProcess/PageClient.h:38, from /tmp/nix-build-webkitgtk-2.8.5.drv-0/webkitgtk-2.8.5/Source/WebKit2/UIProcess/WebPageProxy.cpp:61: /tmp/nix-build-webkitgtk-2.8.5.drv-0/webkitgtk-2.8.5/Source/WebCore/platform/graphics/gstreamer/GUniquePtrGStreamer.h:25:41: fatal error: gst/pbutils/install-plugins.h: No such file or directory #include <gst/pbutils/install-plugins.h> ^ compilation terminated. Source/WebKit2/CMakeFiles/WebKit2.dir/build.make:6367: recipe for target 'Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/WebPageProxy.cpp.o' failed make[2]: *** [Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/WebPageProxy.cpp.o] Error 1 ...