Bug 148891

Summary: AX: Mavericks: Text cursor does not move along with VoiceOver cursor for text fields
Product: WebKit Reporter: chris fleizach <cfleizach>
Component: AccessibilityAssignee: chris fleizach <cfleizach>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, buildbot, commit-queue, dmazzoni, jcraig, jdiggs, mario, rniwa, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari 9   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
buildbot: commit-queue-
Archive of layout-test-results from ews103 for mac-mavericks
none
Archive of layout-test-results from ews106 for mac-mavericks-wk2
none
patch
none
patch
buildbot: commit-queue-
Archive of layout-test-results from ews103 for mac-mavericks
none
Archive of layout-test-results from ews106 for mac-mavericks-wk2
none
patch
none
patch
none
patch ap: review+

Description chris fleizach 2015-09-04 23:41:51 PDT
0. Machine running 13F34 + ToT
1. Go to facebook.com
2. Turn on VoiceOver.
3. Go to any field besides the first one with VoiceOver cursor.
4. Type into the field.

* RESULTS
Text is inserted into the first field and not the one that has VoiceOver focus.

* REGRESSION
r179820

<rdar://problem/22566548>
Comment 1 chris fleizach 2015-09-05 00:31:52 PDT
Created attachment 260679 [details]
patch
Comment 2 Build Bot 2015-09-05 01:10:52 PDT
Comment on attachment 260679 [details]
patch

Attachment 260679 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/142211

New failing tests:
accessibility/mac/setting-attributes-is-asynchronous.html
Comment 3 Build Bot 2015-09-05 01:10:55 PDT
Created attachment 260680 [details]
Archive of layout-test-results from ews103 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 4 Build Bot 2015-09-05 01:11:28 PDT
Comment on attachment 260679 [details]
patch

Attachment 260679 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/142213

New failing tests:
accessibility/mac/setting-attributes-is-asynchronous.html
accessibility/mac/focus-setting-selection-syncronizing-not-clearing.html
Comment 5 Build Bot 2015-09-05 01:11:33 PDT
Created attachment 260681 [details]
Archive of layout-test-results from ews106 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 6 chris fleizach 2015-09-05 09:13:28 PDT
Created attachment 260685 [details]
patch
Comment 7 WebKit Commit Bot 2015-09-05 09:14:27 PDT
Attachment 260685 [details] did not pass style-queue:


ERROR: LayoutTests/platform/mac/TestExpectations:1184:  Path does not exist.  [test/expectations] [5]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 chris fleizach 2015-09-05 09:15:38 PDT
Created attachment 260687 [details]
patch
Comment 9 Build Bot 2015-09-05 09:47:18 PDT
Comment on attachment 260687 [details]
patch

Attachment 260687 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/143161

New failing tests:
accessibility/mac/setting-attributes-is-asynchronous.html
Comment 10 Build Bot 2015-09-05 09:47:22 PDT
Created attachment 260689 [details]
Archive of layout-test-results from ews103 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 11 Build Bot 2015-09-05 09:53:32 PDT
Comment on attachment 260687 [details]
patch

Attachment 260687 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/143172

New failing tests:
accessibility/mac/setting-attributes-is-asynchronous.html
accessibility/mac/focus-setting-selection-syncronizing-not-clearing.html
Comment 12 Build Bot 2015-09-05 09:53:36 PDT
Created attachment 260690 [details]
Archive of layout-test-results from ews106 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 13 chris fleizach 2015-09-05 23:06:21 PDT
Created attachment 260707 [details]
patch
Comment 14 Mario Sanchez Prada 2015-09-07 09:47:38 PDT
Comment on attachment 260707 [details]
patch

It seems to be clean on EWS now
Comment 15 WebKit Commit Bot 2015-09-07 23:24:30 PDT
Comment on attachment 260707 [details]
patch

Clearing flags on attachment: 260707

Committed r189483: <http://trac.webkit.org/changeset/189483>
Comment 16 WebKit Commit Bot 2015-09-07 23:24:37 PDT
All reviewed patches have been landed.  Closing bug.
Comment 17 chris fleizach 2015-09-09 15:06:15 PDT
Created attachment 260877 [details]
patch

this change can also work on Yosemite (just not mavericks)
Comment 18 chris fleizach 2015-09-10 09:54:30 PDT
Created attachment 260933 [details]
patch
Comment 19 chris fleizach 2015-09-10 17:57:38 PDT
http://trac.webkit.org/changeset/189598