| Summary: | Web Inspector: Improve prepare-ChangeLog for multiple cases | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||
| Component: | Web Inspector | Assignee: | Joseph Pecoraro <joepeck> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bburg, commit-queue, dbates, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
Created attachment 260667 [details]
[PATCH] Proposed Fix
Comment on attachment 260667 [details] [PATCH] Proposed Fix Clearing flags on attachment: 260667 Committed r189435: <http://trac.webkit.org/changeset/189435> All reviewed patches have been landed. Closing bug. |
* SUMMARY Improve prepare-ChangeLog for multiple cases 1. InjectedScriptSource.js always produces nothing - this was because the entire file is inside of parenthesis (...) as part of an anonymous function expression (function(){ ... }) 2. Sometimes files start out good but then have produce very weird output later on. - this was because handing of "get" and "set" was too generic and detected map.get(...) as a function 3. Don't detect methods in Object Literals - this was for simplicity, we should do this but probably only at the global scope