Summary: | form.elements should reflect the element ordering after the HTML tree builder algorithm | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||||
Component: | Forms | Assignee: | Keith Rollin <krollin> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | benjamin, cdumez, commit-queue, krollin, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Ryosuke Niwa
2015-09-04 19:17:20 PDT
This bug was found by the newly added test: LayoutTests/http/tests/w3c/html/semantics/forms/the-form-element/form-elements-nameditem-02.html and both Firefox and Chrome pass this test. Created attachment 266827 [details]
Patch
Comment on attachment 266827 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=266827&action=review > Source/WebCore/html/FormAssociatedElement.cpp:54 > + , m_designatedForm(form) "designated" seems rather vague. How about m_parserSetForm or m_formSetByParser? (In reply to comment #4) I thought about that. I even called it something like that at first. But I backed away from that because it wasn't apparent to me that only the parser would be constructing HTMLFormControlElements with non-NULL HTMLFormElements. I'm pretty sure that that's the case *now*, but I didn't see anything that would prevent some other context from specifying an HTMLFormElement. That's why I went with a more general term. But if you disagree with that line of thought, let me know and I'll change it. Created attachment 267012 [details]
Patch
Comment on attachment 267012 [details] Patch Rejecting attachment 267012 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 267012, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in LayoutTests/imported/w3c/ChangeLog contains OOPS!. Full output: http://webkit-queues.webkit.org/results/537562 Created attachment 267015 [details]
Patch
Comment on attachment 267015 [details] Patch Clearing flags on attachment: 267015 Committed r193840: <http://trac.webkit.org/changeset/193840> All reviewed patches have been landed. Closing bug. Comment on attachment 267015 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=267015&action=review > Source/WebCore/html/FormAssociatedElement.h:91 > + FormAssociatedElement(HTMLFormElement*); Should be marked explicit. |