Bug 148858

Summary: [WebGL] Update WebGL 1.0.3 conformance tests
Product: WebKit Reporter: Dean Jackson <dino>
Component: New BugsAssignee: Dean Jackson <dino>
Status: REOPENED    
Severity: Normal CC: ap, bdakin, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=148911
Bug Depends on: 148993    
Bug Blocks:    
Attachments:
Description Flags
Patch bdakin: review+

Dean Jackson
Reported 2015-09-04 17:26:41 PDT
[WebGL] Update WebGL 1.0.3 conformance tests
Attachments
Patch (26.48 KB, patch)
2015-09-04 17:29 PDT, Dean Jackson 		bdakin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-09-04 17:29:27 PDT
<rdar://problem/22588694>
Dean Jackson
Comment 2 2015-09-04 17:29:36 PDT
Created attachment 260659 [details] Patch
Dean Jackson
Comment 3 2015-09-04 17:32:25 PDT
Committed r189407: <http://trac.webkit.org/changeset/189407>
Alexey Proskuryakov
Comment 4 2015-09-04 22:53:37 PDT
Updated webgl/1.0.3/conformance/extensions/webgl-draw-buffers.html fails on Mavericks every time. I will add an expectation, please file a bug and investigate if appropriate.
Alexey Proskuryakov
Comment 5 2015-09-04 22:55:58 PDT
What's interesting is that this test wasn't even changed - it must be a change in one of the support scripts that broke it.
Alexey Proskuryakov
Comment 6 2015-09-08 21:43:57 PDT
This also caused flay timeouts on multiple tests on Yosemite. At least these: webgl/1.0.3/conformance/textures/texture-upload-size.html webgl/1.0.3/conformance/context/context-hidden-alpha.html webgl/1.0.3/conformance/rendering/many-draw-calls.html webgl/1.0.3/conformance/glsl/bugs/complex-glsl-does-not-crash.html Rolling out.
Alexey Proskuryakov
Comment 7 2015-09-08 21:53:04 PDT
Even more strangely, webgl/1.0.2/conformance/textures/tex-image-and-uniform-binding-bugs.html seems to have become flaky at the same time. Something in the modified tests must be affecting behavior across processes.
WebKit Commit Bot
Comment 8 2015-09-08 21:55:45 PDT
Re-opened since this is blocked by bug 148993
Alexey Proskuryakov
Comment 9 2015-09-08 22:03:58 PDT
Rolled out in https://trac.webkit.org/r189533
Alexey Proskuryakov
Comment 10 2015-09-09 10:02:15 PDT
Confirmed that the rollout did help.
Note You need to log in before you can comment on or make changes to this bug.