Summary: | Should have a test to make sure links don't navigate after a cancelled force click | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Beth Dakin <bdakin> | ||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | buildbot, rniwa, thorton | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Beth Dakin
2015-09-04 16:31:37 PDT
Created attachment 260649 [details]
Patch
Comment on attachment 260649 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=260649&action=review > Tools/ChangeLog:3 > + Should have a text to make sure links don't navigate after a cancelled force s/text/test/ > Tools/WebKitTestRunner/mac/EventSenderProxy.mm:470 > +void EventSenderProxy::startAndCancelMouseForceClick() Is this really a fundamental operation? It seems like this is one you should be able to build up from more fine-grained things, so that you can stop changing WKTR and just write tests that use a series of fundamental things. No? But either way is fine :D (In reply to comment #2) > Comment on attachment 260649 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=260649&action=review > > > Tools/ChangeLog:3 > > + Should have a text to make sure links don't navigate after a cancelled force > > s/text/test/ > Eep! Thanks! > > Tools/WebKitTestRunner/mac/EventSenderProxy.mm:470 > > +void EventSenderProxy::startAndCancelMouseForceClick() > > Is this really a fundamental operation? It seems like this is one you should > be able to build up from more fine-grained things, so that you can stop > changing WKTR and just write tests that use a series of fundamental things. > No? > > But either way is fine :D Tim and I talked about this in person. I do think that this is a fundamental operation, and I think that this is the right approach for these tests. http://trac.webkit.org/changeset/189400 Comment on attachment 260649 [details] Patch Attachment 260649 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/141257 New failing tests: fast/events/cancelled-force-click-link-navigation.html Created attachment 260655 [details]
Archive of layout-test-results from ews101 for mac-mavericks
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-mavericks Platform: Mac OS X 10.9.5
Oops! Forgot the expectations. Just committed them: http://trac.webkit.org/changeset/189406 |