Summary: | column-rule-style: outset/inset doesn't work | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||
Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bdakin, commit-queue, esprehn+autocc, glenn, hyatt, kondapallykalyan, mcatanzaro, webkit-bug-importer, zalan | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 148813 | ||||||
Attachments: |
|
Description
Ryosuke Niwa
2015-09-04 13:01:34 PDT
Outset seems to be painted properly. However the reference test seems somewhat odd with display: table and border collapsing on. (which produces the double stripes). I am not sure what the intention was with this reference setup. (In reply to comment #2) > Outset seems to be painted properly. However the reference test seems > somewhat odd with display: table and border collapsing on. (which produces > the double stripes). > I am not sure what the intention was with this reference setup. Oh, it's because of this: "'border-style' values of column-rule are interpreted as in the collapsing border model in which case 'inset' value is drawn the same as 'ridge'. " Created attachment 261331 [details]
Patch
*** Bug 148811 has been marked as a duplicate of this bug. *** Comment on attachment 261331 [details]
Patch
r=me
Comment on attachment 261331 [details] Patch Clearing flags on attachment: 261331 Committed r189916: <http://trac.webkit.org/changeset/189916> All reviewed patches have been landed. Closing bug. These tests: imported/w3c/css/css-multicol-1/multicol-rule-inset-000.xht [ ImageOnlyFailure ] imported/w3c/css/css-multicol-1/multicol-rule-outset-000.xht [ ImageOnlyFailure ] Are still failing on the GTK port, see bug #152823. |