Bug 148790

Summary: Web Inspector: Test RuntimeAgent.parse, detecting if a script parse error is recoverable
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, oliver, sbarati, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix
none
[PATCH] Proposed Fix none

Description Joseph Pecoraro 2015-09-04 01:14:20 PDT
* SUMMARY
Test RuntimeAgent.parse, detecting if a script parse error is recoverable.

Make unterminated literal detection more consistent for numeric literals.
Comment 1 Radar WebKit Bug Importer 2015-09-04 01:14:39 PDT
<rdar://problem/22574076>
Comment 2 Joseph Pecoraro 2015-09-04 01:15:30 PDT
Created attachment 260578 [details]
[PATCH] Proposed Fix
Comment 3 Joseph Pecoraro 2015-09-04 01:18:00 PDT
Comment on attachment 260578 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=260578&action=review

> LayoutTests/inspector/runtime/parse.html:73
> +            testSource("`");     // template string
> +            testSource("`${1}"); // template string

Perhaps template strings (and multi-line comments) should be treated as Recoverable. This would allow us to type multi-line comments and template strings in the console (and jsc) more easily. Thoughts?
Comment 4 Timothy Hatcher 2015-09-04 07:50:48 PDT
(In reply to comment #3)
> Comment on attachment 260578 [details]
> [PATCH] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=260578&action=review
> 
> > LayoutTests/inspector/runtime/parse.html:73
> > +            testSource("`");     // template string
> > +            testSource("`${1}"); // template string
> 
> Perhaps template strings (and multi-line comments) should be treated as
> Recoverable. This would allow us to type multi-line comments and template
> strings in the console (and jsc) more easily. Thoughts?

I think it would make sense to allow multi-line in these cases.
Comment 5 Joseph Pecoraro 2015-09-04 11:26:37 PDT
Created attachment 260603 [details]
[PATCH] Proposed Fix
Comment 6 Joseph Pecoraro 2015-09-04 11:26:53 PDT
> > Perhaps template strings (and multi-line comments) should be treated as
> > Recoverable. This would allow us to type multi-line comments and template
> > strings in the console (and jsc) more easily. Thoughts?
> 
> I think it would make sense to allow multi-line in these cases.

Done!
Comment 7 WebKit Commit Bot 2015-09-04 12:49:01 PDT
Comment on attachment 260603 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 260603

Committed r189371: <http://trac.webkit.org/changeset/189371>
Comment 8 WebKit Commit Bot 2015-09-04 12:49:06 PDT
All reviewed patches have been landed.  Closing bug.