Summary: | Web Inspector: Test RuntimeAgent.parse, detecting if a script parse error is recoverable | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||
Component: | Web Inspector | Assignee: | Joseph Pecoraro <joepeck> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, oliver, saam, timothy, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Joseph Pecoraro
2015-09-04 01:14:20 PDT
Created attachment 260578 [details]
[PATCH] Proposed Fix
Comment on attachment 260578 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=260578&action=review > LayoutTests/inspector/runtime/parse.html:73 > + testSource("`"); // template string > + testSource("`${1}"); // template string Perhaps template strings (and multi-line comments) should be treated as Recoverable. This would allow us to type multi-line comments and template strings in the console (and jsc) more easily. Thoughts? (In reply to comment #3) > Comment on attachment 260578 [details] > [PATCH] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=260578&action=review > > > LayoutTests/inspector/runtime/parse.html:73 > > + testSource("`"); // template string > > + testSource("`${1}"); // template string > > Perhaps template strings (and multi-line comments) should be treated as > Recoverable. This would allow us to type multi-line comments and template > strings in the console (and jsc) more easily. Thoughts? I think it would make sense to allow multi-line in these cases. Created attachment 260603 [details]
[PATCH] Proposed Fix
> > Perhaps template strings (and multi-line comments) should be treated as
> > Recoverable. This would allow us to type multi-line comments and template
> > strings in the console (and jsc) more easily. Thoughts?
>
> I think it would make sense to allow multi-line in these cases.
Done!
Comment on attachment 260603 [details] [PATCH] Proposed Fix Clearing flags on attachment: 260603 Committed r189371: <http://trac.webkit.org/changeset/189371> All reviewed patches have been landed. Closing bug. |