Bug 148775

Summary: [Cocoa] Add system-language-specific tests
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: ap
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Myles C. Maxfield
Reported 2015-09-03 19:36:40 PDT
[Cocoa] Add system-language-specific tests
Attachments
Patch (61.71 KB, patch)
2015-09-03 19:39 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (22.37 KB, patch)
2015-09-03 19:41 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2015-09-03 19:39:12 PDT
Created attachment 260555 [details] Patch
Myles C. Maxfield
Comment 2 2015-09-03 19:39:25 PDT
This patch relies on https://bugs.webkit.org/show_bug.cgi?id=148671
Myles C. Maxfield
Comment 3 2015-09-03 19:41:58 PDT
Created attachment 260556 [details] Patch
Alexey Proskuryakov
Comment 4 2015-09-04 11:56:23 PDT
Comment on attachment 260556 [details] Patch The patch is not up for review, and EWS hasn't processed it. Looks good to me though.
Myles C. Maxfield
Comment 5 2015-09-12 21:10:19 PDT
Committed r189670: <http://trac.webkit.org/changeset/189670>
Alexey Proskuryakov
Comment 6 2015-09-12 21:54:34 PDT
fast/text/international/system-language/han-quotes.html fails on Mavericks and Yosemite. Also, there are several tests that were expected to fail, but passed: fast/text/international/system-language/arabic-glyph-cache-fill-combine.html fast/text/international/system-language/hindi-system-font-punctuation.html fast/text/international/system-language/system-font-punctuation.html
Alexey Proskuryakov
Comment 7 2015-09-14 09:32:12 PDT
Skipped the tests on Windows and on iOS WebKit1 in r189732. > fast/text/international/system-language/han-quotes.html fails on Mavericks and Yosemite. Myles updated the results in r189671. > Also, there are several tests that were expected to fail, but passed: Still an issue. These tests pass on Mavericks, both WK1 and WK2. Are they bad tests?
Myles C. Maxfield
Comment 8 2015-09-14 16:24:28 PDT
(In reply to comment #7) > > Also, there are several tests that were expected to fail, but passed: > > Still an issue. These tests pass on Mavericks, both WK1 and WK2. Are they > bad tests? Nope - they should be marked as able to pass or fail on non-iOS platforms. They only (used to) trigger the bad case on iOS; the test isn't really relevant on Mac.
Myles C. Maxfield
Comment 9 2015-09-14 16:32:36 PDT
Marked as such in r189758: <http://trac.webkit.org/changeset/189758>
Note You need to log in before you can comment on or make changes to this bug.