Bug 148772

Summary: Implement the signed division instruction in WebAssembly
Product: WebKit Reporter: Sukolsak Sakshuwong <sukolsak>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: basile_clement, benjamin, commit-queue, fpizlo, ggaren, keith_miller, mark.lam, msaboff, saam, sukolsak, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 146064, 148791    
Attachments:
Description Flags
Patch
none
Patch
ggaren: review+
Patch none

Sukolsak Sakshuwong
Reported 2015-09-03 19:13:16 PDT
Implement the signed division instruction for WebAssembly files generated by pack-asmjs <https://github.com/WebAssembly/polyfill-prototype-1>.
Attachments
Patch (13.79 KB, patch)
2015-09-03 19:32 PDT, Sukolsak Sakshuwong 		no flags
DetailsFormatted DiffDiff
Patch (12.46 KB, patch)
2015-09-04 01:30 PDT, Sukolsak Sakshuwong 		ggaren: review+
DetailsFormatted DiffDiff
Patch (12.41 KB, patch)
2015-09-04 14:45 PDT, Sukolsak Sakshuwong 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Sukolsak Sakshuwong
Comment 1 2015-09-03 19:32:06 PDT
Created attachment 260553 [details] Patch
WebKit Commit Bot
Comment 2 2015-09-03 19:35:23 PDT
Attachment 260553 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/wasm/WASMFunctionCompiler.h:255: JIT_OPERATION is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sukolsak Sakshuwong
Comment 3 2015-09-04 01:30:23 PDT
Created attachment 260579 [details] Patch
WebKit Commit Bot
Comment 4 2015-09-04 01:32:33 PDT
Attachment 260579 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/wasm/WASMFunctionCompiler.h:255: JIT_OPERATION is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 5 2015-09-04 13:58:05 PDT
Comment on attachment 260579 [details] Patch r=me
Sukolsak Sakshuwong
Comment 6 2015-09-04 14:45:03 PDT
Created attachment 260623 [details] Patch Update to ToT after this patch <https://bugs.webkit.org/show_bug.cgi?id=148793> landed.
WebKit Commit Bot
Comment 7 2015-09-04 14:47:56 PDT
Attachment 260623 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/wasm/WASMFunctionCompiler.h:282: JIT_OPERATION is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 8 2015-09-04 15:00:57 PDT
Comment on attachment 260623 [details] Patch r=me
WebKit Commit Bot
Comment 9 2015-09-04 15:47:30 PDT
Comment on attachment 260623 [details] Patch Clearing flags on attachment: 260623 Committed r189396: <http://trac.webkit.org/changeset/189396>
WebKit Commit Bot
Comment 10 2015-09-04 15:47:35 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.