Bug 148772

Summary: Implement the signed division instruction in WebAssembly
Product: WebKit Reporter: Sukolsak Sakshuwong <sukolsak>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: basile_clement, benjamin, commit-queue, fpizlo, ggaren, keith_miller, mark.lam, msaboff, saam, sukolsak, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 146064, 148791    
Attachments:
Description Flags
Patch
none
Patch
ggaren: review+
Patch none

Description Sukolsak Sakshuwong 2015-09-03 19:13:16 PDT 
Implement the signed division instruction for WebAssembly files generated by pack-asmjs <https://github.com/WebAssembly/polyfill-prototype-1>.
Comment 1 Sukolsak Sakshuwong 2015-09-03 19:32:06 PDT 
Created attachment 260553 [details]
Patch
Comment 2 WebKit Commit Bot 2015-09-03 19:35:23 PDT 
Attachment 260553 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/wasm/WASMFunctionCompiler.h:255:  JIT_OPERATION is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sukolsak Sakshuwong 2015-09-04 01:30:23 PDT 
Created attachment 260579 [details]
Patch
Comment 4 WebKit Commit Bot 2015-09-04 01:32:33 PDT 
Attachment 260579 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/wasm/WASMFunctionCompiler.h:255:  JIT_OPERATION is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Geoffrey Garen 2015-09-04 13:58:05 PDT 
Comment on attachment 260579 [details]
Patch

r=me
Comment 6 Sukolsak Sakshuwong 2015-09-04 14:45:03 PDT 
Created attachment 260623 [details]
Patch

Update to ToT after this patch <https://bugs.webkit.org/show_bug.cgi?id=148793> landed.
Comment 7 WebKit Commit Bot 2015-09-04 14:47:56 PDT 
Attachment 260623 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/wasm/WASMFunctionCompiler.h:282:  JIT_OPERATION is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Geoffrey Garen 2015-09-04 15:00:57 PDT 
Comment on attachment 260623 [details]
Patch

r=me
Comment 9 WebKit Commit Bot 2015-09-04 15:47:30 PDT 
Comment on attachment 260623 [details]
Patch

Clearing flags on attachment: 260623

Committed r189396: <http://trac.webkit.org/changeset/189396>
Comment 10 WebKit Commit Bot 2015-09-04 15:47:35 PDT 
All reviewed patches have been landed.  Closing bug.