Bug 148758 – Need to be able to test default behaviors on force click

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Beth Dakin]

Need to be able to test default behaviors on force click

[Beth Dakin]

Created attachment 260539 [details]
Patch

[WebKit Commit Bot]

Attachment 260539 [details] did not pass style-queue:


ERROR: Tools/WebKitTestRunner/mac/EventSenderProxy.mm:376:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Tools/WebKitTestRunner/mac/EventSenderProxy.mm:377:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Tools/WebKitTestRunner/mac/EventSenderProxy.mm:378:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Tools/WebKitTestRunner/mac/EventSenderProxy.mm:380:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Tools/WebKitTestRunner/mac/EventSenderProxy.mm:381:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Tools/WebKitTestRunner/mac/EventSenderProxy.mm:382:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Tools/WebKitTestRunner/mac/EventSenderProxy.mm:438:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Tools/WebKitTestRunner/mac/EventSenderProxy.mm:439:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Tools/WebKitTestRunner/mac/EventSenderProxy.mm:440:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Tools/WebKitTestRunner/mac/EventSenderProxy.mm:442:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Tools/WebKitTestRunner/mac/EventSenderProxy.mm:443:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Tools/WebKitTestRunner/mac/EventSenderProxy.mm:444:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 12 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Radar WebKit Bug Importer]

<rdar://problem/22569900>

[Tim Horton]

Comment on attachment 260539 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=260539&action=review

> Tools/WebKitTestRunner/mac/EventSenderProxy.mm:102
> +    _eventSender_subtype = NSWindowExposedEventType;

This is zero, so I think you should just omit it (I don't think this is really meant to be NSWindowExposedEventType, it just happens to be the same as 0).

> Tools/WebKitTestRunner/mac/EventSenderProxy.mm:374
> +    if ([m_testController->mainWebView()->platformView() hitTest:[event locationInWindow]])

Why bother with the hit test? We don't use its result, and don't need to do it.

[Beth Dakin]

(In reply to comment #4)
> Comment on attachment 260539 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=260539&action=review
> 
> > Tools/WebKitTestRunner/mac/EventSenderProxy.mm:102
> > +    _eventSender_subtype = NSWindowExposedEventType;
> 
> This is zero, so I think you should just omit it (I don't think this is
> really meant to be NSWindowExposedEventType, it just happens to be the same
> as 0).

You're right! I don't seem to need it.

> 
> > Tools/WebKitTestRunner/mac/EventSenderProxy.mm:374
> > +    if ([m_testController->mainWebView()->platformView() hitTest:[event locationInWindow]])
> 
> Why bother with the hit test? We don't use its result, and don't need to do
> it.

Good catch! I removed it.

[Beth Dakin]

Created attachment 260566 [details]
Patch

[Beth Dakin]

Created attachment 260594 [details]
Patch

[Build Bot]

Comment on attachment 260594 [details]
Patch

Attachment 260594 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/140258

New failing tests:
fast/events/force-click-on-link-navigation.html

[Build Bot]

Created attachment 260596 [details]
Archive of layout-test-results from ews103 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Beth Dakin]

Created attachment 260600 [details]
Patch

[Tim Horton]

Comment on attachment 260600 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=260600&action=review

> Tools/WebKitTestRunner/mac/EventSenderProxy.mm:95
> +    _eventSender_momentumPhase = 0;

No need for this since it's ObjC

> Tools/WebKitTestRunner/mac/EventSenderProxy.mm:376
> +static void spinRunLoopForForce()

handleNextPressureEvent() or something! we're not spinning (just handling the next enqueued pressure event), and we should probably be explicit about which event type we're handling.

Actually, since you always -_postDelayed and then spinRunLoopForForce(), you could make it handleForceEventSynchronously(NSEvent *) and do both things inside here! and that will make the other code less repeaty

[Beth Dakin]

http://trac.webkit.org/changeset/189365