Bug 148750

Summary:

Web Inspector: should crash on purpose if InjectedScriptSource.js is unparseable

Product:

WebKit

Reporter:

BJ Burg <bburg>

Component:

Web Inspector

Assignee:

BJ Burg <bburg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

See Also:

https://bugs.webkit.org/show_bug.cgi?id=210794

Bug Depends on:

Bug Blocks:

147066

Attachments:

Description	Flags
Proposed Fix	none

Description BJ Burg 2015-09-03 14:19:13 PDT

If the injected script cannot be parsed as a ScriptObject, the current behavior is to crash some time later.
This patch adds a release assertion after trying to inject the script, and dumps the injected script source text that was embedded into the binary.

Comment 1 BJ Burg 2015-09-03 14:27:54 PDT

Created attachment 260523 [details]
Proposed Fix

Comment 2 WebKit Commit Bot 2015-09-03 15:29:01 PDT

Comment on attachment 260523 [details]
Proposed Fix

Clearing flags on attachment: 260523

Committed r189295: <http://trac.webkit.org/changeset/189295>

Comment 3 WebKit Commit Bot 2015-09-03 15:29:05 PDT

All reviewed patches have been landed.  Closing bug.

Comment 4 Radar WebKit Bug Importer 2015-09-03 17:48:25 PDT

<rdar://problem/22569879>