Bug 148747

Summary: [Win] Implement DOMNode::attributes.
Product: WebKit Reporter: peavo
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham
Priority: P2    
Version: WebKit Nightly Build   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
Patch bfulgham: review+

Description peavo 2015-09-03 12:20:28 PDT 
This method is not implemented on Windows.
Comment 1 peavo 2015-09-03 12:23:30 PDT 
Created attachment 260508 [details]
Patch
Comment 2 Brent Fulgham 2015-09-08 09:22:12 PDT 
Comment on attachment 260508 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=260508&action=review

Looks great!

> Source/WebKit/win/DOMCoreClasses.cpp:218
> +    *result = 0;

Why not nullptr?
Comment 3 peavo 2015-09-08 09:35:49 PDT 
(In reply to comment #2)
> Comment on attachment 260508 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=260508&action=review
> 
> Looks great!
> 
> > Source/WebKit/win/DOMCoreClasses.cpp:218
> > +    *result = 0;
> 
> Why not nullptr?

Thanks! Will update before landing :)
Comment 4 peavo 2015-09-08 11:21:23 PDT 
Committed r189497: <http://trac.webkit.org/changeset/189497>.