Bug 148745

Summary: Improve access specifier use in RenderObject
Product: WebKit Reporter: Adenilson Cavalcanti Silva <savagobr>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Adenilson Cavalcanti Silva 2015-09-03 11:48:45 PDT 
Probably thanks to changes along the years, RenderObject has access specifiers all over the place.

This patch will remove 4 unneeded specifiers while keeping private functions grouped together.
Comment 1 Adenilson Cavalcanti Silva 2015-09-03 11:50:19 PDT 
Created attachment 260505 [details]
Patch
Comment 2 Myles C. Maxfield 2015-09-03 13:13:04 PDT 
Comment on attachment 260505 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=260505&action=review

> Source/WebCore/rendering/RenderObject.h:844
> +    // Helper functions. Dangerous to use!

This comment is not helpful.
Comment 3 WebKit Commit Bot 2015-09-03 14:03:52 PDT 
Comment on attachment 260505 [details]
Patch

Clearing flags on attachment: 260505

Committed r189286: <http://trac.webkit.org/changeset/189286>
Comment 4 WebKit Commit Bot 2015-09-03 14:03:57 PDT 
All reviewed patches have been landed.  Closing bug.