Bug 148745

Summary:

Improve access specifier use in RenderObject

Product:

WebKit

Reporter:

Adenilson Cavalcanti Silva <savagobr>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc, glenn, kondapallykalyan

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Adenilson Cavalcanti Silva

Reported 2015-09-03 11:48:45 PDT

Probably thanks to changes along the years, RenderObject has access specifiers all over the place. This patch will remove 4 unneeded specifiers while keeping private functions grouped together.

Attachments
Patch (3.56 KB, patch) 2015-09-03 11:50 PDT, Adenilson Cavalcanti Silva	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Adenilson Cavalcanti Silva

Comment 1 2015-09-03 11:50:19 PDT

Created attachment 260505 [details] Patch

Myles C. Maxfield

Comment 2 2015-09-03 13:13:04 PDT

Comment on attachment 260505 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=260505&action=review > Source/WebCore/rendering/RenderObject.h:844 > + // Helper functions. Dangerous to use! This comment is not helpful.

WebKit Commit Bot

Comment 3 2015-09-03 14:03:52 PDT

Comment on attachment 260505 [details] Patch Clearing flags on attachment: 260505 Committed r189286: <http://trac.webkit.org/changeset/189286>

WebKit Commit Bot

Comment 4 2015-09-03 14:03:57 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.