Bug 148739

Summary:

Move SecurityOriginData from WK2 to WebCore

Product:

WebKit

Reporter:

Brady Eidson <beidson>

Component:

WebCore Misc.

Assignee:

Brady Eidson <beidson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, rniwa

Priority:

Version:

Safari 9

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch v1	thorton: review+
Patch v2 - EWS run	buildbot: commit-queue-
Archive of layout-test-results from ews106 for mac-mavericks-wk2	none
v3 - EWS run	none

Brady Eidson

Reported 2015-09-03 11:13:47 PDT

Move SecurityOriginData from WK2 to WebCoreSecurityOriginData

Attachments
Patch v1 (94.54 KB, patch) 2015-09-03 12:29 PDT, Brady Eidson	thorton: review+	Details Formatted Diff Diff
Patch v2 - EWS run (97.25 KB, patch) 2015-09-03 12:57 PDT, Brady Eidson	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews106 for mac-mavericks-wk2 (756.11 KB, application/zip) 2015-09-03 13:45 PDT, Build Bot	no flags	Details
v3 - EWS run (97.51 KB, patch) 2015-09-03 15:01 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Brady Eidson

Comment 1 2015-09-03 12:29:34 PDT

Created attachment 260510 [details] Patch v1

WebKit Commit Bot

Comment 2 2015-09-03 12:31:48 PDT

Attachment 260510 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKUserContentController.mm:41: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.h:66: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.h:67: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.h:68: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:130: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:150: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:170: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIUIClient.h:88: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIUIClient.h:89: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIUIClient.h:90: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 10 in 48 files If any of these errors are false positives, please file a bug against check-webkit-style.

Brady Eidson

Comment 3 2015-09-03 12:45:57 PDT

(In reply to comment #2) > Attachment 260510 [details] did not pass style-queue: > > > ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKUserContentController.mm:41: > Alphabetical sorting problem. [build/include_order] [4] This one was legit, fixing before landing. The others are typical style-bot-not-understanding-c++-lambdas nonsense

Brady Eidson

Comment 4 2015-09-03 12:57:22 PDT

Created attachment 260513 [details] Patch v2 - EWS run

WebKit Commit Bot

Comment 5 2015-09-03 12:59:15 PDT

Attachment 260513 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.h:66: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.h:67: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.h:68: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:130: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:150: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:170: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIUIClient.h:88: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIUIClient.h:89: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIUIClient.h:90: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/gtk/WebKitUIClient.cpp:65: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/gtk/WebKitUIClient.cpp:71: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/gtk/WebKitUIClient.cpp:76: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 12 in 49 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 6 2015-09-03 13:44:57 PDT

Comment on attachment 260513 [details] Patch v2 - EWS run Attachment 260513 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/137385 Number of test failures exceeded the failure limit.

Build Bot

Comment 7 2015-09-03 13:45:00 PDT

Created attachment 260517 [details] Archive of layout-test-results from ews106 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

Brady Eidson

Comment 8 2015-09-03 15:01:14 PDT

Created attachment 260529 [details] v3 - EWS run

WebKit Commit Bot

Comment 9 2015-09-03 15:03:33 PDT

Attachment 260529 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.h:66: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.h:67: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.h:68: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:130: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:150: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:170: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIUIClient.h:88: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIUIClient.h:89: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIUIClient.h:90: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/gtk/WebKitUIClient.cpp:65: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/gtk/WebKitUIClient.cpp:71: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/gtk/WebKitUIClient.cpp:76: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 12 in 49 files If any of these errors are false positives, please file a bug against check-webkit-style.

Brady Eidson

Comment 10 2015-09-03 16:33:42 PDT

GTK EWS is taking *forever* on v3, but it passed v2, so landing this now.

Brady Eidson

Comment 11 2015-09-03 16:35:16 PDT

https://trac.webkit.org/changeset/189313

Note You need to log in before you can comment on or make changes to this bug.