Bug 148735

Summary: REGRESSION(r188206): [EFL] Missing to adjust scrollbar size to ewk_view_contents_size_get API test
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebKit EFLAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hs85.jeong, lucas.de.marchi, ossy
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 147725    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Gyuyoung Kim
Reported 2015-09-02 18:46:10 PDT
I missed to fix other tests in r189256. I'm sorry about it. I upload an additional fix again :(
Attachments
Patch (1.99 KB, patch)
2015-09-02 18:46 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (1.90 KB, patch)
2015-11-23 00:37 PST, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2015-09-02 18:46:50 PDT
Created attachment 260471 [details] Patch
Gyuyoung Kim
Comment 2 2015-09-02 21:57:13 PDT
Comment on attachment 260471 [details] Patch Hmm, EFL API test is now fine. Is this flaky ? :(
Hunseop Jeong
Comment 3 2015-11-19 22:36:03 PST
gyuyoung, ewk_view_contents_size_get API test have failed for a long time. It doesn't looks flaky. https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/25635/steps/API%20tests/logs/stdio [ RUN ] EWK2ViewTest.ewk_view_contents_size_get ../../Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:1328: Failure Value of: contentsWidth Actual: 390 Expected: environment->defaultWidth() / 2 Which is: 400 ../../Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:1329: Failure Value of: contentsHeight Actual: 290 Expected: environment->defaultHeight() / 2 Which is: 300 [ FAILED ] EWK2ViewTest.ewk_view_contents_size_get (219 ms)
Gyuyoung Kim
Comment 4 2015-11-23 00:37:56 PST
Created attachment 266081 [details] Patch
Gyuyoung Kim
Comment 5 2015-11-23 00:39:18 PST
(In reply to comment #3) > gyuyoung, ewk_view_contents_size_get API test have failed for a long time. > It doesn't looks flaky. > > https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/ > builds/25635/steps/API%20tests/logs/stdio > > [ RUN ] EWK2ViewTest.ewk_view_contents_size_get > ../../Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:1328: Failure > Value of: contentsWidth > Actual: 390 > Expected: environment->defaultWidth() / 2 > Which is: 400 > ../../Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:1329: Failure > Value of: contentsHeight > Actual: 290 > Expected: environment->defaultHeight() / 2 > Which is: 300 > [ FAILED ] EWK2ViewTest.ewk_view_contents_size_get (219 ms) I forget this. But this test was fine as soon as I update this fix. It is weird. Anyway now I reproduce this failure locally. And this patch is still valid for the failure.
Gyuyoung Kim
Comment 6 2015-11-23 07:01:24 PST
Ossy, could you take a look ?
Csaba Osztrogonác
Comment 7 2015-11-23 07:21:16 PST
Comment on attachment 266081 [details] Patch rs=me
WebKit Commit Bot
Comment 8 2015-11-23 17:17:59 PST
Comment on attachment 266081 [details] Patch Clearing flags on attachment: 266081 Committed r192754: <http://trac.webkit.org/changeset/192754>
WebKit Commit Bot
Comment 9 2015-11-23 17:18:02 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.