Bug 148716

Summary: MutationObserver should accept attributeFilter, attributeOldValue, and characterDataOldValue on their own
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, esprehn+autocc, kangil.han, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar, WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fixes the bug none

Description Ryosuke Niwa 2015-09-02 10:31:19 PDT 
Right now MutationObserver require attributes to be present when attributeFilter and attributeOldValue are set,
and characterData when characterDataOldValue is set but DOM4 implicitly set those attributes now.
Comment 1 Ryosuke Niwa 2015-09-02 10:38:24 PDT 
Created attachment 260424 [details]
Fixes the bug
Comment 2 Chris Dumez 2015-09-02 10:47:59 PDT 
Comment on attachment 260424 [details]
Fixes the bug

r=me
Comment 3 Ryosuke Niwa 2015-09-02 13:51:21 PDT 
<rdar://problem/22545128>
Comment 4 WebKit Commit Bot 2015-09-02 15:42:06 PDT 
Comment on attachment 260424 [details]
Fixes the bug

Rejecting attachment 260424 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 260424, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
', 'dcommit', '--rmdir']" exit_code: 139 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
Authentication realm: <http://svn.webkit.org:80> Mac OS Forge
Password for 'commit-queue@webkit.org': 
Authentication realm: <http://svn.webkit.org:80> Mac OS Forge
Username: error: git-svn died of signal 11

Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 139 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
Current branch master is up to date.

Full output: http://webkit-queues.webkit.org/results/134352
Comment 5 WebKit Commit Bot 2015-09-02 20:08:20 PDT 
Comment on attachment 260424 [details]
Fixes the bug

Clearing flags on attachment: 260424

Committed r189271: <http://trac.webkit.org/changeset/189271>
Comment 6 WebKit Commit Bot 2015-09-02 20:08:34 PDT 
All reviewed patches have been landed.  Closing bug.