Bug 148694

Summary:

Rename ShadowRoot::hostElement to shadowRoot::host to match the latest spec

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

DOM

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, cdumez, commit-queue, kling, koivisto, rniwa, sam

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

148695

Attachments:

Description	Flags
Refactoring	none
Archive of layout-test-results from ews102 for mac-mavericks	none
Addresses the review comment	none

Ryosuke Niwa

Reported 2015-09-01 16:38:43 PDT

ShadowHost::hostElement has been renamed to ShadowRost::host in the latest shadow DOM spec. Match that.

Attachments
Refactoring (19.81 KB, patch) 2015-09-01 16:42 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-mavericks (614.58 KB, application/zip) 2015-09-01 17:17 PDT, Build Bot	no flags	Details
Addresses the review comment (3.96 KB, patch) 2015-09-01 19:29 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Ryosuke Niwa

Comment 1 2015-09-01 16:42:06 PDT

Created attachment 260393 [details] Refactoring

Chris Dumez

Comment 2 2015-09-01 16:48:06 PDT

Comment on attachment 260393 [details] Refactoring View in context: https://bugs.webkit.org/attachment.cgi?id=260393&action=review r=me % nits. > Source/WebCore/dom/Element.cpp:1663 > + oldRoot->setHost(0); nullptr > Source/WebCore/dom/Node.cpp:1038 > return 0; nullptr > Source/WebCore/dom/ShadowRoot.h:56 > + Element* host() const { return m_hostElement; } So we don't want to rename the member variable as well?

Build Bot

Comment 3 2015-09-01 17:17:49 PDT

Comment on attachment 260393 [details] Refactoring Attachment 260393 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/131220 New failing tests: http/tests/w3c/dom/nodes/ParentNode-querySelector-All.html

Build Bot

Comment 4 2015-09-01 17:17:52 PDT

Created attachment 260395 [details] Archive of layout-test-results from ews102 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-mavericks Platform: Mac OS X 10.9.5

Chris Dumez

Comment 5 2015-09-01 17:21:18 PDT

(In reply to comment #3) > Comment on attachment 260393 [details] > Refactoring > > Attachment 260393 [details] did not pass mac-ews (mac): > Output: http://webkit-queues.webkit.org/results/131220 > > New failing tests: > http/tests/w3c/dom/nodes/ParentNode-querySelector-All.html This is a flake.

WebKit Commit Bot

Comment 6 2015-09-01 17:55:07 PDT

Comment on attachment 260393 [details] Refactoring Clearing flags on attachment: 260393 Committed r189239: <http://trac.webkit.org/changeset/189239>

WebKit Commit Bot

Comment 7 2015-09-01 17:55:11 PDT

All reviewed patches have been landed. Closing bug.

Chris Dumez

Comment 8 2015-09-01 18:30:11 PDT

(In reply to comment #6) > Comment on attachment 260393 [details] > Refactoring > > Clearing flags on attachment: 260393 > > Committed r189239: <http://trac.webkit.org/changeset/189239> What about my nit fixes?

Ryosuke Niwa

Comment 9 2015-09-01 18:49:59 PDT

Oh oops, I missed your comments. Will fix in a minute.

Ryosuke Niwa

Comment 10 2015-09-01 19:29:47 PDT

Reopening to attach new patch.

Ryosuke Niwa

Comment 11 2015-09-01 19:29:49 PDT

Created attachment 260401 [details] Addresses the review comment

Ryosuke Niwa

Comment 12 2015-09-01 19:31:57 PDT

Comment on attachment 260401 [details] Addresses the review comment Clearing flags on attachment: 260401 Committed r189243: <http://trac.webkit.org/changeset/189243>

Ryosuke Niwa

Comment 13 2015-09-01 19:32:03 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.