Summary: | Rename ShadowRoot::hostElement to shadowRoot::host to match the latest spec | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||||
Component: | DOM | Assignee: | Ryosuke Niwa <rniwa> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | buildbot, cdumez, commit-queue, kling, koivisto, rniwa, sam | ||||||||
Priority: | P2 | ||||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 148695 | ||||||||||
Attachments: |
|
Description
Ryosuke Niwa
2015-09-01 16:38:43 PDT
Created attachment 260393 [details]
Refactoring
Comment on attachment 260393 [details] Refactoring View in context: https://bugs.webkit.org/attachment.cgi?id=260393&action=review r=me % nits. > Source/WebCore/dom/Element.cpp:1663 > + oldRoot->setHost(0); nullptr > Source/WebCore/dom/Node.cpp:1038 > return 0; nullptr > Source/WebCore/dom/ShadowRoot.h:56 > + Element* host() const { return m_hostElement; } So we don't want to rename the member variable as well? Comment on attachment 260393 [details] Refactoring Attachment 260393 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/131220 New failing tests: http/tests/w3c/dom/nodes/ParentNode-querySelector-All.html Created attachment 260395 [details]
Archive of layout-test-results from ews102 for mac-mavericks
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-mavericks Platform: Mac OS X 10.9.5
(In reply to comment #3) > Comment on attachment 260393 [details] > Refactoring > > Attachment 260393 [details] did not pass mac-ews (mac): > Output: http://webkit-queues.webkit.org/results/131220 > > New failing tests: > http/tests/w3c/dom/nodes/ParentNode-querySelector-All.html This is a flake. Comment on attachment 260393 [details] Refactoring Clearing flags on attachment: 260393 Committed r189239: <http://trac.webkit.org/changeset/189239> All reviewed patches have been landed. Closing bug. (In reply to comment #6) > Comment on attachment 260393 [details] > Refactoring > > Clearing flags on attachment: 260393 > > Committed r189239: <http://trac.webkit.org/changeset/189239> What about my nit fixes? Oh oops, I missed your comments. Will fix in a minute. Reopening to attach new patch. Created attachment 260401 [details]
Addresses the review comment
Comment on attachment 260401 [details] Addresses the review comment Clearing flags on attachment: 260401 Committed r189243: <http://trac.webkit.org/changeset/189243> All reviewed patches have been landed. Closing bug. |