Summary: | Web Inspector: add pixel area column to layout timeline view | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | BJ Burg <bburg> | ||||||
Component: | Web Inspector | Assignee: | Matt Baker <mattbaker> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
BJ Burg
2015-09-01 08:33:03 PDT
We had area. I can't remember why we removed it. Created attachment 281627 [details]
[Patch] Proposed Fix
Comment on attachment 281627 [details]
[Patch] Proposed Fix
r=me
Where is the px^2 string used?
Comment on attachment 281627 [details] [Patch] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=281627&action=review > Source/WebInspectorUI/UserInterface/Views/LayoutTimelineDataGridNode.js:52 > + area: this._record.width * this._record.height, > width: this._record.width, > height: this._record.height, > area: this._record.width * this._record.height, Area is already here on line 52. Comment on attachment 281627 [details]
[Patch] Proposed Fix
Clearing review queue. Please remove duplicate 'area'.
Created attachment 282473 [details]
[Patch] Proposed Fix
Comment on attachment 282473 [details] [Patch] Proposed Fix Clearing flags on attachment: 282473 Committed r202713: <http://trac.webkit.org/changeset/202713> All reviewed patches have been landed. Closing bug. |