Bug 148676

Summary: Radio buttons have a fixed border radius making them look square when resized
Product: WebKit Reporter: Robin Whittleton <robin>
Component: FormsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Minor CC: buildbot, dino, jonlee, rniwa, simon.fraser, tom.byers, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: Safari 8   
Hardware: iPhone / iPad   
OS: Unspecified   
Attachments:
Description Flags
Radio / checkbox resizing testcase
none
Screenshot of the issue
none
Patch
thorton: review+, buildbot: commit-queue-
Archive of layout-test-results from ews107 for mac-elcapitan-wk2 none

Description Robin Whittleton 2015-09-01 07:31:50 PDT
Created attachment 260363 [details]
Radio / checkbox resizing testcase

Radio buttons on iOS (unlike on OS X) can be resized by styling width and height which is great. There’s a small bug though: the size of the border radius that defines a radio button as a circle appears to be set in pixels. This means that as the height and width of the radio increases they look progressively more square. Can this radius be set at 50% instead of a fixed pixel value?

I’ve attached a screenshot of iOS 8.4.1’s behaviour, and a testcase.
Comment 1 Robin Whittleton 2015-09-01 07:32:22 PDT
Created attachment 260364 [details]
Screenshot of the issue
Comment 2 Radar WebKit Bug Importer 2017-01-05 14:21:59 PST
<rdar://problem/29889892>
Comment 3 Simon Fraser (smfr) 2017-01-05 17:13:04 PST
Created attachment 298156 [details]
Patch
Comment 4 Build Bot 2017-01-05 18:13:17 PST
Comment on attachment 298156 [details]
Patch

Attachment 298156 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2841043

New failing tests:
imported/w3c/web-platform-tests/IndexedDB/idbcursor-direction-index-keyrange.htm
Comment 5 Build Bot 2017-01-05 18:13:20 PST
Created attachment 298159 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 6 Simon Fraser (smfr) 2017-01-05 18:23:57 PST
https://trac.webkit.org/r210423