Bug 14863 – RenderObject.cpp->drawBorder

• Component: Layout and Rendering
• Status: RESOLVED INVALID

[wangwei]

in RenderObject.cpp 
line 962:
if (adjbw1 == 0 && adjbw2 == 0) {
				graphicsContext->save(); // ADD
                graphicsContext->setStrokeStyle(NoStroke); // Problem ??
                graphicsContext->setFillColor(c);
line 980(979):
}
				graphicsContext->restore(); // ADD
line 1078(1076):
case SOLID: {
			graphicsContext->save(); // ADD
            graphicsContext->setStrokeStyle(NoStroke); // Problem ??
            graphicsContext->setFillColor(c);
line 1084(1081):
graphicsContext->restore();
                return;// ADD
line 1115(1111):
graphicsContext->drawConvexPolygon(4, quad);
graphicsContext->restore(); // ADD
            break;

Error in GraphicsContextCairo.cpp
void GraphicsContext::drawLine(const IntPoint& point1, const IntPoint& point2)
{
    if (paintingDisabled())
        return;

    StrokeStyle style = strokeStyle();
    if (style == NoStroke) // ============here=====
        return;

called from drawLineForText (for link??)

[Mark Rowe (bdash)]

I was unable to understand your bug report at all.  If you have a specific issue to report, please provide a description of the problem you are seeing.  If you are submitting a code change, please submit it as a patch.  See <http://webkit.org/coding/contributing.html> for information about how to do this.

[David Kilzer (:ddkilzer)]

(In reply to comment #1)
> I was unable to understand your bug report at all.  If you have a specific
> issue to report, please provide a description of the problem you are seeing. 
> If you are submitting a code change, please submit it as a patch.  See
> <http://webkit.org/coding/contributing.html> for information about how to do
> this.

The first part (RenderObject.cpp ) is a patch.  I don't understand the changes for the second part (GraphicsContextCairo.cpp).

[David Kilzer (:ddkilzer)]

Created attachment 15808 [details]
Patch for RenderObject.cpp

Converted the changes to RenderObject.cpp in Comment #0 into a patch.

[Dave Hyatt]

Comment on attachment 15808 [details]
Patch for RenderObject.cpp

I don't see why save/restore are necessary here.

[David Kilzer (:ddkilzer)]

Closing bug again.  Wang, please reopen it if you feel there is still an issue with an explanation or a patch.  Thanks!