Bug 148613

Summary: Web Inspector: Command-Enter for selected JS in Debugger/Sources shouldn't change the focus
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Animated GIF] Bug
none
Patch
none
Patch
timothy: review+
Patch none

Description Nikita Vasilyev 2015-08-29 21:03:48 PDT
Created attachment 260233 [details]
[Animated GIF] Bug

Steps:
1. Select some JS in debugger.
2. Press Command-Enter

Actual:
Split console showed up, console prompt became focused.

Expected:
Split console showed up, the focus is still on the same selected text in the debugger. I can still move the cursor around the text.
Comment 1 Radar WebKit Bug Importer 2015-08-29 21:05:15 PDT
<rdar://problem/22491374>
Comment 2 Nikita Vasilyev 2015-08-29 21:36:34 PDT
Created attachment 260234 [details]
Patch
Comment 3 Nikita Vasilyev 2015-08-29 21:55:01 PDT
Created attachment 260235 [details]
Patch
Comment 4 Timothy Hatcher 2015-08-31 11:04:59 PDT
Comment on attachment 260235 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=260235&action=review

> Source/WebInspectorUI/UserInterface/Views/ConsoleTabContentView.js:45
>          super.shown();
> +        WebInspector.consoleContentView.prompt.focus();

New line between these lines.
Comment 5 Nikita Vasilyev 2015-08-31 22:24:51 PDT
Created attachment 260353 [details]
Patch
Comment 6 WebKit Commit Bot 2015-08-31 23:18:32 PDT
Comment on attachment 260353 [details]
Patch

Clearing flags on attachment: 260353

Committed r189206: <http://trac.webkit.org/changeset/189206>
Comment 7 WebKit Commit Bot 2015-08-31 23:18:38 PDT
All reviewed patches have been landed.  Closing bug.