Bug 148613

Summary:

Web Inspector: Command-Enter for selected JS in Debugger/Sources shouldn't change the focus

Product:

WebKit

Reporter:

Nikita Vasilyev <nvasilyev>

Component:

Web Inspector

Assignee:

Nikita Vasilyev <nvasilyev>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[Animated GIF] Bug	none
Patch	none
Patch	timothy: review+
Patch	none

Nikita Vasilyev

Reported 2015-08-29 21:03:48 PDT

Created attachment 260233 [details] [Animated GIF] Bug Steps: 1. Select some JS in debugger. 2. Press Command-Enter Actual: Split console showed up, console prompt became focused. Expected: Split console showed up, the focus is still on the same selected text in the debugger. I can still move the cursor around the text.

Attachments
[Animated GIF] Bug (436.12 KB, image/gif) 2015-08-29 21:03 PDT, Nikita Vasilyev	no flags	Details
Patch (2.04 KB, patch) 2015-08-29 21:36 PDT, Nikita Vasilyev	no flags	Details Formatted Diff Diff
Patch (2.15 KB, patch) 2015-08-29 21:55 PDT, Nikita Vasilyev	timothy: review+	Details Formatted Diff Diff
Patch (2.12 KB, patch) 2015-08-31 22:24 PDT, Nikita Vasilyev	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2015-08-29 21:05:15 PDT

<rdar://problem/22491374>

Nikita Vasilyev

Comment 2 2015-08-29 21:36:34 PDT

Created attachment 260234 [details] Patch

Nikita Vasilyev

Comment 3 2015-08-29 21:55:01 PDT

Created attachment 260235 [details] Patch

Timothy Hatcher

Comment 4 2015-08-31 11:04:59 PDT

Comment on attachment 260235 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=260235&action=review > Source/WebInspectorUI/UserInterface/Views/ConsoleTabContentView.js:45 > super.shown(); > + WebInspector.consoleContentView.prompt.focus(); New line between these lines.

Nikita Vasilyev

Comment 5 2015-08-31 22:24:51 PDT

Created attachment 260353 [details] Patch

WebKit Commit Bot

Comment 6 2015-08-31 23:18:32 PDT

Comment on attachment 260353 [details] Patch Clearing flags on attachment: 260353 Committed r189206: <http://trac.webkit.org/changeset/189206>

WebKit Commit Bot

Comment 7 2015-08-31 23:18:38 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.