Bug 148612

Summary:

Web Inspector: tighten up lifetimes for InspectorController-owned objects; add brace initializers to agents

Product:

WebKit

Reporter:

BJ Burg <bburg>

Component:

Web Inspector

Assignee:

BJ Burg <bburg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, graouts, joepeck, mattbaker, mkwst, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

148481

Attachments:

Description	Flags
Proposed Fix	none
Proposed Fix (rebased for EWS)	none

Description BJ Burg 2015-08-29 15:41:54 PDT

Morally, they are owned by InspectorController. InstrumentingAgents has to be Ref<> because of sharing with instrumentation cookies for now.

While I touch every file, might as well clean up to be consistently using brace initializers in the declaration.

Comment 1 Radar WebKit Bug Importer 2015-08-29 15:42:58 PDT

<rdar://problem/22490698>

Comment 2 BJ Burg 2015-08-29 15:50:19 PDT

Created attachment 260227 [details]
Proposed Fix

Depends on other bugs, so it won't apply yet.

Comment 3 Joseph Pecoraro 2015-08-31 11:27:16 PDT

Comment on attachment 260227 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=260227&action=review

r=me

> Source/JavaScriptCore/inspector/agents/JSGlobalObjectDebuggerAgent.h:58
> +    InspectorConsoleAgent* m_consoleAgent  { nullptr };

Nit: double space

Comment 4 BJ Burg 2015-09-01 10:03:31 PDT

Created attachment 260366 [details]
Proposed Fix (rebased for EWS)

Comment 5 BJ Burg 2015-09-01 10:52:41 PDT

Committed r189218: <http://trac.webkit.org/changeset/189218>