Bug 148605 – Web Inspector: copy({x:1}) should copy "{x:1}", not "[object Object]"

• Component: Web Inspector
• Status: RESOLVED FIXED

[Nikita Vasilyev]

Steps:
1. Open console
2. Enter copy({x:1})
3. Press Command-V

Expected:
{x: 1}

Actual:
[object Object]


Possibly a regression.

[Radar WebKit Bug Importer]

<rdar://problem/22487630>

[Joseph Pecoraro]

Created attachment 267395 [details]
[PATCH] Proposed Fix

Other browsers (FireFox and Chrome) seem to use formatting stringification `JSON.stringify(object, null, "  ")`, so this follows suit.

[Blaze Burg]

Comment on attachment 267395 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=267395&action=review

r=me, this is awesome!

> LayoutTests/inspector/console/command-line-api-copy.html:24
> +    function commandLineAPICopyAndPaste(expression, callback) {

If you want to add a comment, then rename the function instead. Perhaps "copyAndPasteObjectUsingCommandLineAPI"

[Joseph Pecoraro]

Created attachment 267396 [details]
[PATCH] For Landing

[Build Bot]

Comment on attachment 267395 [details]
[PATCH] Proposed Fix

Attachment 267395 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/564062

New failing tests:
http/tests/inspector/console/cross-domain-inspected-node-access.html

[Build Bot]

Created attachment 267399 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 267395 [details]
[PATCH] Proposed Fix

Attachment 267395 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/564078

New failing tests:
http/tests/inspector/console/cross-domain-inspected-node-access.html

[Build Bot]

Created attachment 267400 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 267395 [details]
[PATCH] Proposed Fix

Attachment 267395 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/564178

New failing tests:
http/tests/inspector/console/cross-domain-inspected-node-access.html

[Build Bot]

Created attachment 267403 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Joseph Pecoraro]

Created attachment 267407 [details]
[PATCH] For Landing

Interestingly, this adjusted some line numbers in warnings. I'll just rebase them.

[Build Bot]

Comment on attachment 267407 [details]
[PATCH] For Landing

Attachment 267407 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/564398

New failing tests:
imported/w3c/web-platform-tests/XMLHttpRequest/interfaces.html
imported/w3c/web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_datauri_02.html
imported/w3c/web-platform-tests/dom/nodes/Node-isEqualNode.xhtml
imported/w3c/web-platform-tests/html/dom/interfaces.html
imported/w3c/web-platform-tests/XMLHttpRequest/timeout-sync.htm
imported/w3c/web-platform-tests/dom/interfaces.html
imported/w3c/web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_datauri_01.html
imported/w3c/web-platform-tests/XMLHttpRequest/responsetype.html

[Build Bot]

Created attachment 267409 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 267407 [details]
[PATCH] For Landing

Attachment 267407 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/564392

New failing tests:
imported/w3c/web-platform-tests/XMLHttpRequest/interfaces.html
imported/w3c/web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_datauri_02.html
imported/w3c/web-platform-tests/dom/nodes/Node-isEqualNode.xhtml
imported/w3c/web-platform-tests/XMLHttpRequest/timeout-sync.htm
imported/w3c/web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_datauri_01.html
imported/w3c/web-platform-tests/XMLHttpRequest/responsetype.html

[Build Bot]

Created attachment 267410 [details]
Archive of layout-test-results from ews117 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Timothy Hatcher]

Comment on attachment 267395 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=267395&action=review

> Source/WebCore/inspector/CommandLineAPIModuleSource.js:308
> +                string = JSON.stringify(object, null, "  ");

Why 2 space indent? Why not 4? (Interesting that you can also pass a number for the number of spaces instead of a string too, according to MDN.)

[Joseph Pecoraro]

(In reply to comment #16)
> > Source/WebCore/inspector/CommandLineAPIModuleSource.js:308
> > +                string = JSON.stringify(object, null, "  ");
> 
> Why 2 space indent? Why not 4? (Interesting that you can also pass a number
> for the number of spaces instead of a string too, according to MDN.)

2 matches what Firefox and Chrome did. I figured we should be consistent.

[Joseph Pecoraro]

Hmm, I don't know why so many tests have suddenly become flakey. I will have to investigate tomorrow.

[Joseph Pecoraro]

Created attachment 267449 [details]
[PATCH] Try Again - For Bots

[Build Bot]

Comment on attachment 267449 [details]
[PATCH] Try Again - For Bots

Attachment 267449 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/566126

New failing tests:
http/tests/inspector/console/cross-domain-inspected-node-access.html

[Build Bot]

Created attachment 267452 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 267449 [details]
[PATCH] Try Again - For Bots

Attachment 267449 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/566128

New failing tests:
http/tests/inspector/console/cross-domain-inspected-node-access.html

[Build Bot]

Created attachment 267453 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 267449 [details]
[PATCH] Try Again - For Bots

Attachment 267449 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/566125

New failing tests:
http/tests/inspector/console/cross-domain-inspected-node-access.html

[Build Bot]

Created attachment 267454 [details]
Archive of layout-test-results from ews117 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Timothy Hatcher]

Created attachment 269914 [details]
Third Time is a Charm

[Build Bot]

Comment on attachment 269914 [details]
Third Time is a Charm

Attachment 269914 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/742732

New failing tests:
http/tests/inspector/console/cross-domain-inspected-node-access.html

[Build Bot]

Created attachment 269920 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 269914 [details]
Third Time is a Charm

Attachment 269914 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/742744

New failing tests:
http/tests/inspector/console/cross-domain-inspected-node-access.html

[Build Bot]

Created attachment 269922 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 269914 [details]
Third Time is a Charm

Attachment 269914 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/742807

New failing tests:
http/tests/inspector/console/cross-domain-inspected-node-access.html

[Build Bot]

Created attachment 269930 [details]
Archive of layout-test-results from ews113 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Blaze Burg]

Looks like this just needs to be rebased for new line numbers.

[Joseph Pecoraro]

Created attachment 270870 [details]
[PATCH] Attempt 4 for bots

[WebKit Commit Bot]

Comment on attachment 270870 [details]
[PATCH] Attempt 4 for bots

Clearing flags on attachment: 270870

Committed r196270: <http://trac.webkit.org/changeset/196270>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.