Bug 148593

Summary:

[Mac] Restructure WebMediaSessionManager for testing

Product:

WebKit

Reporter:

Eric Carlson <eric.carlson>

Component:

Media

Assignee:

Eric Carlson <eric.carlson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, jer.noble, ossy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch.	jer.noble: review+
Patch for landing.	none

Description Eric Carlson 2015-08-28 15:19:39 PDT

Restructure so it is possible to use a Mock target picker.

Comment 1 Radar WebKit Bug Importer 2015-08-28 15:20:20 PDT

<rdar://problem/22483489>

Comment 2 Eric Carlson 2015-08-28 15:55:20 PDT

Created attachment 260189 [details]
Proposed patch.

Comment 3 Jer Noble 2015-08-28 16:04:44 PDT

Comment on attachment 260189 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=260189&action=review

r=me, with nit.

> Source/WebCore/Modules/mediasession/WebMediaSessionManager.h:48
> +    WEBCORE_EXPORT static WebMediaSessionManager& singleton();

nit: singleton() is a weird nomenclature.  I mean, in other places we use shared(), which implies that it's singleton.  But this object is specifically not a singleton! Because it's overridable, it's a ... dual... ton. Or something.

Comment 4 Eric Carlson 2015-08-28 16:14:27 PDT

Created attachment 260193 [details]
Patch for landing.

Comment 5 WebKit Commit Bot 2015-08-28 17:15:13 PDT

Comment on attachment 260193 [details]
Patch for landing.

Clearing flags on attachment: 260193

Committed r189135: <http://trac.webkit.org/changeset/189135>

Comment 6 Csaba Osztrogonác 2015-09-04 03:56:09 PDT

The patch already landed, let's close the bug.