Bug 148592 – Fix run-webkit-tests --additional-env-var="DYLD_INSERT_LIBRARIES=..."

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Alexey Proskuryakov]

run-webkit-tests doesn't respect DYLD_INSERT_LIBRARIES passed as --additional-env-var.

This is a problem when testing an ASan-built framework with a non-ASan build of WebKit. When main executable is not built with ASAn, you need to insert ASan's dynamic library manually.

[Alexey Proskuryakov]

Created attachment 260182 [details]
proposed fix

[Tim Horton]

Comment on attachment 260182 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=260182&action=review

> Tools/Scripts/webkitpy/port/base.py:860
> +            env[name] = env[name] + ":" + value

what if env[name] has a trailing :

[Alexey Proskuryakov]

> what if env[name] has a trailing :

I don't know! Would guess that "::" is probably OK, but also this shouldn't happen.

[Tim Horton]

(In reply to comment #3)
> > what if env[name] has a trailing :
> 
> I don't know! Would guess that "::" is probably OK, but also this shouldn't
> happen.

Safe in this case. Not safe if you're mutating $PATH. But sure :D

[WebKit Commit Bot]

Comment on attachment 260182 [details]
proposed fix

Clearing flags on attachment: 260182

Committed r189128: <http://trac.webkit.org/changeset/189128>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Alexey Proskuryakov]

> Safe in this case. Not safe if you're mutating $PATH. But sure :D

Turns out that at least for bash, a trailing colon in PATH needs to be converted to a double colon when appending:

"A null directory name may appear as two adjacent colons, or as an initial or trailing colon."

Obviously not a behavior to rely upon.