Bug 148583
| Summary: | "webkit-patch upload" does not catch style violations in the new ChangeLog entry | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Zack Weinberg <zackw> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | cfleizach, dbates, ddkilzer |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=196016 | ||
Zack Weinberg
"webkit-patch upload" runs the linter before asking you to edit the ChangeLog, so if you make a style error while editing the ChangeLog (e.g. indenting it with tabs, the way they do it in *every other project that uses GNU-style changelogs*, ahem) it doesn't get caught until after you've uploaded the patch to bugzilla.complain about tabs in the
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |