Bug 148565

Summary:

[Cocoa] Unify showGlyphsWithAdvances

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

New Bugs

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, rniwa

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews103 for mac-mavericks	none
Archive of layout-test-results from ews106 for mac-mavericks-wk2	none
Patch	dino: review+

Myles C. Maxfield

Reported 2015-08-27 23:55:09 PDT

[Cocoa] Unify showGlyphsWithAdvances

Attachments
Patch (4.16 KB, patch) 2015-08-27 23:57 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-mavericks (2.36 MB, application/zip) 2015-08-28 00:29 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews106 for mac-mavericks-wk2 (2.40 MB, application/zip) 2015-08-28 00:33 PDT, Build Bot	no flags	Details
Patch (4.85 KB, patch) 2015-08-29 01:16 PDT, Myles C. Maxfield	dino: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Myles C. Maxfield

Comment 1 2015-08-27 23:57:14 PDT

Created attachment 260131 [details] Patch

Build Bot

Comment 2 2015-08-28 00:29:03 PDT

Comment on attachment 260131 [details] Patch Attachment 260131 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/115649 New failing tests: css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-019.html svg/clip-path/clip-path-text-002.svg fast/text/text-combine-rendering.html fast/inline/hidpi-rtl-text-does-not-fit-line-and-gets-cut-off.html css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-031.html fast/shapes/shape-outside-floats/shape-outside-floats-inset-rounded-bottom-right.html svg/clip-path/clip-path-text-004.svg fast/shapes/shape-outside-floats/shape-outside-floats-inset-rounded-top-left.html svg/clip-path/clip-path-text-001.svg svg/clip-path/clip-path-text-005.svg css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-030.html fast/shapes/shape-outside-floats/shape-outside-floats-inset-rounded-top-right.html svg/custom/hidpi-masking-clipping.svg css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-031.html mathml/presentation/scripts-subsup.html fast/shapes/shape-outside-floats/shape-outside-rounded-inset.html fast/regions/overflow/overflow-size-change-with-stacking-context-rtl.html fast/shapes/shape-outside-floats/shape-outside-floats-ellipse-000.html fast/shapes/shape-outside-floats/shape-outside-floats-inset-rounded-bottom-left.html css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-027.html fast/ruby/ruby-justification.html svg/clip-path/clip-path-text-003.svg css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-030.html fast/shapes/shape-outside-floats/shape-outside-floats-circle-000.html

Build Bot

Comment 3 2015-08-28 00:29:06 PDT

Created attachment 260132 [details] Archive of layout-test-results from ews103 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-mavericks Platform: Mac OS X 10.9.5

Build Bot

Comment 4 2015-08-28 00:33:37 PDT

Comment on attachment 260131 [details] Patch Attachment 260131 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/115656 New failing tests: css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-019.html svg/clip-path/clip-path-text-002.svg fast/text/text-combine-rendering.html fast/inline/hidpi-rtl-text-does-not-fit-line-and-gets-cut-off.html css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-031.html fast/shapes/shape-outside-floats/shape-outside-floats-inset-rounded-bottom-right.html svg/clip-path/clip-path-text-004.svg fast/shapes/shape-outside-floats/shape-outside-floats-inset-rounded-top-left.html svg/clip-path/clip-path-text-001.svg svg/clip-path/clip-path-text-005.svg css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-030.html fast/shapes/shape-outside-floats/shape-outside-floats-inset-rounded-top-right.html svg/custom/hidpi-masking-clipping.svg css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-031.html mathml/presentation/scripts-subsup.html fast/shapes/shape-outside-floats/shape-outside-rounded-inset.html fast/regions/overflow/overflow-size-change-with-stacking-context-rtl.html fast/shapes/shape-outside-floats/shape-outside-floats-ellipse-000.html fast/shapes/shape-outside-floats/shape-outside-floats-inset-rounded-bottom-left.html css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-027.html fast/ruby/ruby-justification.html svg/clip-path/clip-path-text-003.svg css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-030.html fast/shapes/shape-outside-floats/shape-outside-floats-circle-000.html

Build Bot

Comment 5 2015-08-28 00:33:41 PDT

Created attachment 260133 [details] Archive of layout-test-results from ews106 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

Myles C. Maxfield

Comment 6 2015-08-29 01:16:55 PDT

Created attachment 260222 [details] Patch

Myles C. Maxfield

Comment 7 2015-08-31 13:32:53 PDT

Committed r189180: <http://trac.webkit.org/changeset/189180>

Note You need to log in before you can comment on or make changes to this bug.