Bug 148561

Summary:

Migrate GraphicsContexts from pointers to references

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

New Bugs

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, rniwa

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	buildbot: commit-queue-
Archive of layout-test-results from ews103 for mac-mavericks	none
Archive of layout-test-results from ews104 for mac-mavericks-wk2	none
Patch	thorton: review+
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Myles C. Maxfield

Reported 2015-08-27 22:14:51 PDT

Migrate from pointers to references for text drawing code

Attachments
Patch (50.52 KB, patch) 2015-08-27 22:45 PDT, Myles C. Maxfield	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-mavericks (886.58 KB, application/zip) 2015-08-27 23:23 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews104 for mac-mavericks-wk2 (949.43 KB, application/zip) 2015-08-27 23:27 PDT, Build Bot	no flags	Details
Patch (689.66 KB, patch) 2015-08-28 19:33 PDT, Myles C. Maxfield	thorton: review+	Details Formatted Diff Diff
Patch (698.01 KB, patch) 2015-08-28 20:58 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (709.74 KB, patch) 2015-08-28 21:21 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (710.45 KB, patch) 2015-08-28 21:29 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (712.29 KB, patch) 2015-08-28 21:46 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (716.67 KB, patch) 2015-08-28 22:09 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (719.24 KB, patch) 2015-08-28 22:39 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (721.51 KB, patch) 2015-08-28 22:56 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Show Obsolete (9) View All Add attachment proposed patch, testcase, etc.

Myles C. Maxfield

Comment 1 2015-08-27 22:45:25 PDT

Created attachment 260125 [details] Patch

Build Bot

Comment 2 2015-08-27 23:23:06 PDT

Comment on attachment 260125 [details] Patch Attachment 260125 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/115456 New failing tests: imported/mozilla/svg/text/simple-fill-gradient.svg imported/mozilla/svg/text-layout-06.svg svg/custom/hidpi-masking-clipping.svg imported/mozilla/svg/text-scale-02.svg

Build Bot

Comment 3 2015-08-27 23:23:09 PDT

Created attachment 260128 [details] Archive of layout-test-results from ews103 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-mavericks Platform: Mac OS X 10.9.5

Build Bot

Comment 4 2015-08-27 23:27:16 PDT

Comment on attachment 260125 [details] Patch Attachment 260125 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/115460 New failing tests: imported/mozilla/svg/text/simple-fill-gradient.svg imported/mozilla/svg/text-layout-06.svg svg/custom/hidpi-masking-clipping.svg imported/mozilla/svg/text-scale-02.svg

Build Bot

Comment 5 2015-08-27 23:27:19 PDT

Created attachment 260129 [details] Archive of layout-test-results from ews104 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

Myles C. Maxfield

Comment 6 2015-08-28 18:52:08 PDT

*** Bug 148590 has been marked as a duplicate of this bug. ***

Myles C. Maxfield

Comment 7 2015-08-28 18:55:17 PDT

*** Bug 148558 has been marked as a duplicate of this bug. ***

Myles C. Maxfield

Comment 8 2015-08-28 19:33:27 PDT

Created attachment 260203 [details] Patch

Tim Horton

Comment 9 2015-08-28 19:38:10 PDT

Comment on attachment 260203 [details] Patch rs=me. sad that the storage on PaintInfo can't be a reference (and then you wouldn't need the getter). maybe in the future?

Myles C. Maxfield

Comment 10 2015-08-28 20:58:20 PDT

Created attachment 260208 [details] Patch

Myles C. Maxfield

Comment 11 2015-08-28 21:21:56 PDT

Created attachment 260209 [details] Patch

Myles C. Maxfield

Comment 12 2015-08-28 21:29:39 PDT

Created attachment 260211 [details] Patch

Myles C. Maxfield

Comment 13 2015-08-28 21:46:11 PDT

Created attachment 260213 [details] Patch