| Summary: | Web Inspector: Type Profiler does not understand Functions within Default Argument Expressions | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||
| Component: | Web Inspector | Assignee: | Joseph Pecoraro <joepeck> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, saam, timothy, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
Created attachment 260119 [details]
[PATCH] Proposed Fix
Comment on attachment 260119 [details] [PATCH] Proposed Fix Clearing flags on attachment: 260119 Committed r189096: <http://trac.webkit.org/changeset/189096> All reviewed patches have been landed. Closing bug. I wonder if the JSC implementation of the type profiler properly handles this. I don't think it does. |
* SUMMARY Type Profiler does not understand Functions within Default Argument Expressions. Default Argument Expressions are currently ignored by our SyntaxTree. * TESTS function testFunctionDeclaration(a=(function(alpha=999){return alpha})(), b=20) { return a + b; }; add2(); (function testFunctionExpression(a=(function(alpha=999){return alpha})(), b=20) { return a + b; })() * RESULTS Expected type bubbles for the inner `function(alpha)...` function expressions, but they were even visited by our annotator. * NOTES No errors or warnings.