Bug 148537

Summary: Adding support for a custom input view controller for WKWebView
Product: WebKit Reporter: Andrew Gold <agold>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WONTFIX    
Severity: Normal CC: beidson, craig, mitz
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch beidson: review-

Andrew Gold
Reported 2015-08-27 14:01:26 PDT
Adding support for a custom input view controller for WKWebView
Attachments
Patch (5.62 KB, patch)
2015-08-27 14:05 PDT, Andrew Gold 		no flags
DetailsFormatted DiffDiff
Patch (5.86 KB, patch)
2015-08-27 14:25 PDT, Andrew Gold 		beidson: review-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andrew Gold
Comment 1 2015-08-27 14:05:14 PDT
Created attachment 260086 [details] Patch
Anders Carlsson
Comment 2 2015-08-27 14:07:11 PDT
Comment on attachment 260086 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=260086&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:134 > +@property (nonatomic, retain) UIInputViewController *customInputViewController; This needs to follow the SPI guidelines.
Andrew Gold
Comment 3 2015-08-27 14:25:24 PDT
Created attachment 260089 [details] Patch
mitz
Comment 4 2015-12-18 08:13:18 PST
We ended up doing something a little more refined in bug 150395.
Brady Eidson
Comment 5 2017-04-24 19:09:42 PDT
Comment on attachment 260089 [details] Patch This patch has been pending review since 2015 with no recent activity. It seems unlikely that it would even still apply to trunk in its current form. Clearing from the review queue. Feel free to update and resubmit if the patch is still relevant.
Note You need to log in before you can comment on or make changes to this bug.