Bug 148537

Summary:

Adding support for a custom input view controller for WKWebView

Product:

WebKit

Reporter:

Andrew Gold <agold>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

beidson, craig, mitz

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	beidson: review-

Description Andrew Gold 2015-08-27 14:01:26 PDT

Adding support for a custom input view controller for WKWebView

Comment 1 Andrew Gold 2015-08-27 14:05:14 PDT

Created attachment 260086 [details]
Patch

Comment 2 Anders Carlsson 2015-08-27 14:07:11 PDT

Comment on attachment 260086 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=260086&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:134
> +@property (nonatomic, retain) UIInputViewController *customInputViewController;

This needs to follow the SPI guidelines.

Comment 3 Andrew Gold 2015-08-27 14:25:24 PDT

Created attachment 260089 [details]
Patch

Comment 4 mitz 2015-12-18 08:13:18 PST

We ended up doing something a little more refined in bug 150395.

Comment 5 Brady Eidson 2017-04-24 19:09:42 PDT

Comment on attachment 260089 [details]
Patch

This patch has been pending review since 2015 with no recent activity.
It seems unlikely that it would even still apply to trunk in its current form.

Clearing from the review queue.

Feel free to update and resubmit if the patch is still relevant.