Summary: | Incorrect implementation of ArrayImpl's equality operator | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | rick | ||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Minor | ||||||
Priority: | P3 | ||||||
Version: | 312.x | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
rick
2007-08-01 12:04:02 PDT
Created attachment 15785 [details]
Patch that fixes the described bug (includes ChangeLog differences)
(In reply to comment #1) > Created an attachment (id=15785) [edit] > Patch that fixes the described bug (includes ChangeLog differences) This really needs a test case. (In reply to comment #2) > (In reply to comment #1) > > Created an attachment (id=15785) [edit] > > Patch that fixes the described bug (includes ChangeLog differences) > > This really needs a test case. Where can I add such a test case? The problem is that the bug wouldn't show itself with current higher level functionality (i.e. a layout test or a JavaScriptCore test). I couldn't find anything about adding a lower level C++ test program. For example, something like: #include "ArrayImpl.h" int main() { WebCore::ArrayImpl a(1, 1); WebCore::ArrayImpl b(2, 1); // return 1 on error return a == b ? 1 : 0; } (In reply to comment #3) > (In reply to comment #2) > > This really needs a test case. > > Where can I add such a test case? The problem is that the bug wouldn't show > itself with current higher level functionality (i.e. a layout test or a > JavaScriptCore test). I couldn't find anything about adding a lower level C++ > test program. For example, something like: Sorry, by "test case" I meant a layout test (in HTML/JavaScript). Since that's not possible, it's okay not to have one. :) |