Bug 148515

Summary:

Web Inspector: Standardize on CSSStyleSheet.Type enum and move more protocol enum conversion to the manager

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

DoNotImportToRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none

Joseph Pecoraro

Reported 2015-08-26 23:20:27 PDT

* SUMMARY Standardize on CSSStyleSheet.Type enum and move more protocol enum conversion to the manager. `CSS.CSSRule` protocol types send a `CSS.StyleSheetOrigin` enum to the frontend. So we should be using CSSStyleSheet.Type instead of CSSRule.Type.

Attachments
[PATCH] Proposed Fix (22.58 KB, patch) 2015-08-26 23:23 PDT, Joseph Pecoraro	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Joseph Pecoraro

Comment 1 2015-08-26 23:23:00 PDT

Created attachment 260038 [details] [PATCH] Proposed Fix

Blaze Burg

Comment 2 2015-08-27 08:26:49 PDT

Comment on attachment 260038 [details] [PATCH] Proposed Fix r=me

WebKit Commit Bot

Comment 3 2015-08-27 10:37:40 PDT

Comment on attachment 260038 [details] [PATCH] Proposed Fix Clearing flags on attachment: 260038 Committed r189032: <http://trac.webkit.org/changeset/189032>

WebKit Commit Bot

Comment 4 2015-08-27 10:37:44 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.