Bug 148509

Summary: Factor out Lookup invocation
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, dbates, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch andersca: review+

Tim Horton
Reported 2015-08-26 19:54:35 PDT
Factor out Lookup invocation
Attachments
Patch (70.31 KB, patch)
2015-08-26 19:55 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (73.34 KB, patch)
2015-08-27 12:09 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (75.48 KB, patch)
2015-08-27 12:11 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (76.00 KB, patch)
2015-08-27 12:20 PDT, Tim Horton 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2015-08-26 19:55:17 PDT
Created attachment 260022 [details] Patch
Tim Horton
Comment 2 2015-08-27 12:09:21 PDT
Created attachment 260076 [details] Patch
Tim Horton
Comment 3 2015-08-27 12:11:57 PDT
Created attachment 260077 [details] Patch
Tim Horton
Comment 4 2015-08-27 12:20:08 PDT
Created attachment 260079 [details] Patch
Anders Carlsson
Comment 5 2015-08-27 14:16:30 PDT
Comment on attachment 260079 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=260079&action=review > Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm:470 > + return (id<NSImmediateActionAnimationController>)DictionaryLookup::animationControllerForPopup(dictionaryPopupInfo, _wkView, [self](TextIndicator& textIndicator) { Why do you need the cast here?
Tim Horton
Comment 6 2015-08-27 14:19:00 PDT
(In reply to comment #5) > Comment on attachment 260079 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=260079&action=review > > > Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm:470 > > + return (id<NSImmediateActionAnimationController>)DictionaryLookup::animationControllerForPopup(dictionaryPopupInfo, _wkView, [self](TextIndicator& textIndicator) { > > Why do you need the cast here? I don't, anymore! (In a previous version of the patch, it always returned void*)
Tim Horton
Comment 7 2015-08-27 14:25:09 PDT
http://trac.webkit.org/changeset/189052
Note You need to log in before you can comment on or make changes to this bug.