Bug 148509

Summary: Factor out Lookup invocation
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, dbates, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch andersca: review+

Description Tim Horton 2015-08-26 19:54:35 PDT
Factor out Lookup invocation
Comment 1 Tim Horton 2015-08-26 19:55:17 PDT
Created attachment 260022 [details]
Patch
Comment 2 Tim Horton 2015-08-27 12:09:21 PDT
Created attachment 260076 [details]
Patch
Comment 3 Tim Horton 2015-08-27 12:11:57 PDT
Created attachment 260077 [details]
Patch
Comment 4 Tim Horton 2015-08-27 12:20:08 PDT
Created attachment 260079 [details]
Patch
Comment 5 Anders Carlsson 2015-08-27 14:16:30 PDT
Comment on attachment 260079 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=260079&action=review

> Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm:470
> +    return (id<NSImmediateActionAnimationController>)DictionaryLookup::animationControllerForPopup(dictionaryPopupInfo, _wkView, [self](TextIndicator& textIndicator) {

Why do you need the cast here?
Comment 6 Tim Horton 2015-08-27 14:19:00 PDT
(In reply to comment #5)
> Comment on attachment 260079 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=260079&action=review
> 
> > Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm:470
> > +    return (id<NSImmediateActionAnimationController>)DictionaryLookup::animationControllerForPopup(dictionaryPopupInfo, _wkView, [self](TextIndicator& textIndicator) {
> 
> Why do you need the cast here?

I don't, anymore! (In a previous version of the patch, it always returned void*)
Comment 7 Tim Horton 2015-08-27 14:25:09 PDT
http://trac.webkit.org/changeset/189052