Bug 148505

Summary: Update Grid Layout to use fewer magic -1s
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, jfernandez, kondapallykalyan, rego, svillar
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch jfernandez: review+

Description Myles C. Maxfield 2015-08-26 17:48:26 PDT 
Update Grid Layout to use fewer magic -1s
Comment 1 Myles C. Maxfield 2015-08-26 17:50:10 PDT 
Created attachment 260010 [details]
Patch
Comment 2 Myles C. Maxfield 2015-08-26 23:00:52 PDT 
Created attachment 260035 [details]
Patch
Comment 3 Javier Fernandez 2015-08-27 01:10:44 PDT 
Comment on attachment 260010 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=260010&action=review

> Source/WebCore/rendering/RenderGrid.cpp:1301
> +    ASSERT(child.overrideContainingBlockContentLogicalWidth());

Shouldn't we assert child.overrideContainingBlockContentLogicalHeight() as well ?
Comment 4 Myles C. Maxfield 2015-08-27 11:04:01 PDT 
Committed r189037: <http://trac.webkit.org/changeset/189037>