Bug 148505

Summary: Update Grid Layout to use fewer magic -1s
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, jfernandez, kondapallykalyan, rego, svillar
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch jfernandez: review+

Myles C. Maxfield
Reported 2015-08-26 17:48:26 PDT
Update Grid Layout to use fewer magic -1s
Attachments
Patch (6.90 KB, patch)
2015-08-26 17:50 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (6.82 KB, patch)
2015-08-26 23:00 PDT, Myles C. Maxfield 		jfernandez: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2015-08-26 17:50:10 PDT
Created attachment 260010 [details] Patch
Myles C. Maxfield
Comment 2 2015-08-26 23:00:52 PDT
Created attachment 260035 [details] Patch
Javier Fernandez
Comment 3 2015-08-27 01:10:44 PDT
Comment on attachment 260010 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=260010&action=review > Source/WebCore/rendering/RenderGrid.cpp:1301 > + ASSERT(child.overrideContainingBlockContentLogicalWidth()); Shouldn't we assert child.overrideContainingBlockContentLogicalHeight() as well ?
Myles C. Maxfield
Comment 4 2015-08-27 11:04:01 PDT
Committed r189037: <http://trac.webkit.org/changeset/189037>
Note You need to log in before you can comment on or make changes to this bug.