Bug 148499

Summary:

[Cocoa] Generic font families do not consult with the user's preferred language

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

New Bugs

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, dino, jonlee, koivisto, rniwa, simon.fraser, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Archive of layout-test-results from ews102 for mac-mavericks	none
Archive of layout-test-results from ews104 for mac-mavericks-wk2	none
Patch	none
Patch	koivisto: review+

Description Myles C. Maxfield 2015-08-26 17:00:28 PDT

Generic font families do not consult with the user's preferred language

Comment 1 Myles C. Maxfield 2015-08-26 17:08:02 PDT

Created attachment 259997 [details]
Patch

Comment 2 Myles C. Maxfield 2015-08-26 17:09:00 PDT

<rdar://problem/22407296>

Comment 3 Myles C. Maxfield 2015-08-26 17:09:30 PDT

Created attachment 259998 [details]
Patch

Comment 4 Myles C. Maxfield 2015-08-26 17:29:43 PDT

Created attachment 260006 [details]
Patch

Comment 5 Build Bot 2015-08-26 17:54:46 PDT

Comment on attachment 260006 [details]
Patch

Attachment 260006 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/110977

New failing tests:
fast/text/international/locale-sensitive-fonts.html
fast/text/international/font-fallback-to-common-script.html
fast/text/international/lang-sensitive-fonts-xml.xhtml
fast/text/international/lang-sensitive-fonts.html

Comment 6 Build Bot 2015-08-26 17:54:50 PDT

Created attachment 260012 [details]
Archive of layout-test-results from ews102 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-mavericks  Platform: Mac OS X 10.9.5

Comment 7 Build Bot 2015-08-26 18:03:23 PDT

Comment on attachment 260006 [details]
Patch

Attachment 260006 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/111000

New failing tests:
fast/text/international/locale-sensitive-fonts.html
fast/text/international/font-fallback-to-common-script.html
fast/text/international/lang-sensitive-fonts-xml.xhtml
fast/text/international/lang-sensitive-fonts.html

Comment 8 Build Bot 2015-08-26 18:03:27 PDT

Created attachment 260013 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

Comment 9 Myles C. Maxfield 2015-08-26 18:26:38 PDT

The EWS bots' preferred language is just a single item: English.

Comment 10 Myles C. Maxfield 2015-08-26 22:02:34 PDT

Created attachment 260031 [details]
Patch

Comment 11 Myles C. Maxfield 2015-08-26 22:03:06 PDT

Created attachment 260032 [details]
Patch

Comment 12 Antti Koivisto 2015-08-27 11:06:22 PDT

r=me

Comment 13 Myles C. Maxfield 2015-08-27 11:09:38 PDT

Committed r189038: <http://trac.webkit.org/changeset/189038>