Bug 148492

Summary: Web Inspector: agents should send messages through FrontendRouter instead of FrontendChannel
Product: WebKit Reporter: Blaze Burg <bburg>
Component: Web InspectorAssignee: Blaze Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 148538    
Bug Blocks: 148481    
Attachments:
Description Flags
Proposed Fix
none
For EWS
none
For EWS (ios, win)
none
For EWS (win)
none
For EWS (win) none

Blaze Burg
Reported 2015-08-26 14:38:53 PDT
We shouldn't pass around FrontendChannel*, the FrontendRouter should decide which actual channels to use based on the message type.
Attachments
Proposed Fix (95.62 KB, patch)
2015-08-29 09:23 PDT, Blaze Burg 		no flags
DetailsFormatted DiffDiff
For EWS (95.27 KB, patch)
2015-09-04 16:27 PDT, Blaze Burg 		no flags
DetailsFormatted DiffDiff
For EWS (ios, win) (97.16 KB, patch)
2015-09-04 16:54 PDT, Blaze Burg 		no flags
DetailsFormatted DiffDiff
For EWS (win) (97.43 KB, patch)
2015-09-04 17:18 PDT, Blaze Burg 		no flags
DetailsFormatted DiffDiff
For EWS (win) (97.38 KB, patch)
2015-09-04 21:32 PDT, Blaze Burg 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-08-26 14:39:11 PDT
<rdar://problem/22444749>
Blaze Burg
Comment 2 2015-08-29 09:23:50 PDT
Created attachment 260224 [details] Proposed Fix Depends on blocking bug, so it's won't apply yet.
Joseph Pecoraro
Comment 3 2015-09-02 19:04:11 PDT
Comment on attachment 260224 [details] Proposed Fix r=me, but you will likely have to address build issues in other ports, so be aware!
Blaze Burg
Comment 4 2015-09-04 16:27:50 PDT
Created attachment 260646 [details] For EWS
WebKit Commit Bot
Comment 5 2015-09-04 16:29:54 PDT
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Blaze Burg
Comment 6 2015-09-04 16:54:42 PDT
Created attachment 260652 [details] For EWS (ios, win)
Blaze Burg
Comment 7 2015-09-04 17:18:54 PDT
Created attachment 260654 [details] For EWS (win)
Blaze Burg
Comment 8 2015-09-04 21:32:49 PDT
Created attachment 260674 [details] For EWS (win)
Blaze Burg
Comment 9 2015-09-05 09:06:31 PDT
Committed r189433: <http://trac.webkit.org/changeset/189433>
Alex Christensen
Comment 10 2015-09-07 18:57:15 PDT
My WinCairo bot doesn't like this :( Could you take a look? https://build.webkit.org/builders/WinCairo%2064-Bit%20Release/builds/49022/steps/compile-webkit/logs/stdio
Note You need to log in before you can comment on or make changes to this bug.