| Summary: | Web Inspector: agents should send messages through FrontendRouter instead of FrontendChannel | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | BJ Burg <bburg> | ||||||||||||
| Component: | Web Inspector | Assignee: | BJ Burg <bburg> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | achristensen, bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | All | ||||||||||||||
| OS: | All | ||||||||||||||
| Bug Depends on: | 148538 | ||||||||||||||
| Bug Blocks: | 148481 | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
BJ Burg
2015-08-26 14:38:53 PDT
Created attachment 260224 [details]
Proposed Fix
Depends on blocking bug, so it's won't apply yet.
Comment on attachment 260224 [details]
Proposed Fix
r=me, but you will likely have to address build issues in other ports, so be aware!
Created attachment 260646 [details]
For EWS
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`) Created attachment 260652 [details]
For EWS (ios, win)
Created attachment 260654 [details]
For EWS (win)
Created attachment 260674 [details]
For EWS (win)
Committed r189433: <http://trac.webkit.org/changeset/189433> My WinCairo bot doesn't like this :( Could you take a look? https://build.webkit.org/builders/WinCairo%2064-Bit%20Release/builds/49022/steps/compile-webkit/logs/stdio |