Bug 148486

Summary: Media Session: make MediaSessionMetadata a class
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ossy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch
jer.noble: review+, commit-queue: commit-queue-
Patch for landing. none

Eric Carlson
Reported 2015-08-26 11:30:43 PDT
MediaSessionMetadata is defined as a struct, but it is forward declared in several places as a class. Make it a class and rectify the errant forward declarations.
Attachments
Proposed patch (3.06 KB, patch)
2015-08-26 11:39 PDT, Eric Carlson 		jer.noble: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
Patch for landing. (3.02 KB, patch)
2015-08-26 12:35 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2015-08-26 11:39:42 PDT
Created attachment 259966 [details] Proposed patch
Radar WebKit Bug Importer
Comment 2 2015-08-26 12:09:54 PDT
<rdar://problem/22441794>
WebKit Commit Bot
Comment 3 2015-08-26 12:19:13 PDT
Comment on attachment 259966 [details] Proposed patch Rejecting attachment 259966 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 259966, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: of 1 hunk FAILED -- saving rejects to file Source/WebCore/ChangeLog.rej patching file Source/WebCore/Modules/mediasession/MediaSessionMetadata.h patching file Source/WebCore/page/ChromeClient.h patching file Source/WebKit2/ChangeLog patching file Source/WebKit2/Shared/WebCoreArgumentCoders.h patching file Source/WebKit2/UIProcess/WebPageProxy.h Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Jer Noble']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/109924
Eric Carlson
Comment 4 2015-08-26 12:35:51 PDT
Created attachment 259969 [details] Patch for landing.
WebKit Commit Bot
Comment 5 2015-08-26 13:29:22 PDT
Comment on attachment 259969 [details] Patch for landing. Clearing flags on attachment: 259969 Committed r188983: <http://trac.webkit.org/changeset/188983>
Csaba Osztrogonác
Comment 6 2015-09-04 03:57:55 PDT
Already landed, let's close it.
Note You need to log in before you can comment on or make changes to this bug.