Bug 148480

Summary:

Web Inspector: REGRESSION(r188965): BackendDispatcher loses request ids when called re-entrantly

Product:

WebKit

Reporter:

BJ Burg <bburg>

Component:

Web Inspector

Assignee:

BJ Burg <bburg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

146466

Bug Blocks:

Attachments:

Description	Flags
Proposed Fix	none

Description BJ Burg 2015-08-26 09:49:20 PDT

I added an assertion that m_currentRequestId is Nullopt when dispatch() is called, but this should not hold if dispatching a backend command while debugger is paused. I will remove the assertion and add proper scoping for all dispatch() branches.

This caused inspector/dom-debugger/node-removed.html to crash reliably, rather than flakily due to some other JSC bug.

Comment 1 Radar WebKit Bug Importer 2015-08-26 09:51:27 PDT

<rdar://problem/22438652>

Comment 2 BJ Burg 2015-08-26 09:55:17 PDT

Created attachment 259960 [details]
Proposed Fix

Comment 3 Joseph Pecoraro 2015-08-26 11:03:23 PDT

Comment on attachment 259960 [details]
Proposed Fix

r=me

Comment 4 WebKit Commit Bot 2015-08-26 11:53:52 PDT

Comment on attachment 259960 [details]
Proposed Fix

Clearing flags on attachment: 259960

Committed r188976: <http://trac.webkit.org/changeset/188976>

Comment 5 WebKit Commit Bot 2015-08-26 11:53:56 PDT

All reviewed patches have been landed.  Closing bug.