Bug 148476

Summary:

[Cairo] Accelerated canvas should fall back to non-accelerated canvas on creation failure

Product:

WebKit

Reporter:

Jinyoung Hur <hur.ims>

Component:

New Bugs

Assignee:

Jinyoung Hur <hur.ims>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Jinyoung Hur 2015-08-26 08:03:22 PDT

[Cairo] Accelerated canvas should fall back to uunaccelrated canvas on creation failure

Comment 1 Jinyoung Hur 2015-08-26 08:42:28 PDT

Created attachment 259952 [details]
Patch

Comment 2 Jinyoung Hur 2015-08-26 08:44:47 PDT

Cairo-gl backed surface might fail to be created with large dimensions, e.g., 50x32000, depending on the gl implementations. In case of Mac port, ImageBufferCG falls back to a software surface when it fails to create
        IOSurface, an accelerated surface. Though the unaccelerated surface could be slower, it would be better
        to create a working surface than nothing.

Comment 3 Jinyoung Hur 2015-08-26 08:45:43 PDT

Cairo-gl backed surface might fail to be created with large dimensions, e.g., 50x32000, depending on the gl implementations.
In case of Mac port, ImageBufferCG falls back to a software surface when it fails to create IOSurface, an accelerated surface. 
Though the unaccelerated surface could be slower, it would be better to create a working surface than nothing.

Comment 4 Brent Fulgham 2015-08-26 08:59:15 PDT

Comment on attachment 259952 [details]
Patch

r=me.

Comment 5 WebKit Commit Bot 2015-08-26 09:44:59 PDT

Comment on attachment 259952 [details]
Patch

Clearing flags on attachment: 259952

Committed r188968: <http://trac.webkit.org/changeset/188968>

Comment 6 WebKit Commit Bot 2015-08-26 09:45:02 PDT

All reviewed patches have been landed.  Closing bug.