Bug 148464

Summary: [Cocoa] PerformanceTest Layout/RegionsShapes.html is failing
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch aestes: review+

Description Myles C. Maxfield 2015-08-25 22:05:35 PDT 
[Cocoa] PerformanceTest Layout/RegionsShapes.html is failing
Comment 1 Myles C. Maxfield 2015-08-25 22:08:38 PDT 
Created attachment 259924 [details]
Patch
Comment 2 Andy Estes 2015-08-25 22:42:23 PDT 
Comment on attachment 259924 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259924&action=review

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:472
> +    RetainPtr<CFDictionaryRef> attributes = adoptCF(CFDictionaryCreate(kCFAllocatorDefault, keys, values, WTF_ARRAY_LENGTH(keys), &kCFTypeDictionaryKeyCallBacks, &kCFTypeDictionaryValueCallBacks));
> +    RetainPtr<CTFontDescriptorRef> descriptor = adoptCF(CTFontDescriptorCreateWithAttributes(attributes.get()));

I like to use auto in these cases.
Comment 3 Myles C. Maxfield 2015-08-26 17:20:33 PDT 
Committed r189005: <http://trac.webkit.org/changeset/189005>