Bug 148461

Summary: [Win] Simplify menu handling code in WinLauncher
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: Tools / TestsAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, sabouhallawa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: PC   
OS: All   
Bug Depends on: 148451    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Brent Fulgham
Reported 2015-08-25 20:35:20 PDT
Said pointed out in a recent code review that the menu handler for WinLauncher duplicates a bunch of menu item checks with the main WinProc. This patch attempts to follow-up on that suggestion.
Attachments
Patch (3.63 KB, patch)
2015-08-25 20:46 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2015-08-25 20:46:56 PDT
Created attachment 259917 [details] Patch
Said Abou-Hallawa
Comment 2 2015-08-26 09:46:50 PDT
Looks good to me. Unofficial r=me. Thanks for cleaning this part of the code.
WebKit Commit Bot
Comment 3 2015-08-26 10:34:06 PDT
Comment on attachment 259917 [details] Patch Clearing flags on attachment: 259917 Committed r188969: <http://trac.webkit.org/changeset/188969>
WebKit Commit Bot
Comment 4 2015-08-26 10:34:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.