Bug 148461

Summary:

[Win] Simplify menu handling code in WinLauncher

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

Tools / Tests

Assignee:

Brent Fulgham <bfulgham>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, sabouhallawa

Priority:

Version:

WebKit Nightly Build

Hardware:

OS:

All

Bug Depends on:

148451

Bug Blocks:

Attachments:

Description	Flags
Patch	none

Description Brent Fulgham 2015-08-25 20:35:20 PDT

Said pointed out in a recent code review that the menu handler for WinLauncher duplicates a bunch of menu item checks with the main WinProc. This patch attempts to follow-up on that suggestion.

Comment 1 Brent Fulgham 2015-08-25 20:46:56 PDT

Created attachment 259917 [details]
Patch

Comment 2 Said Abou-Hallawa 2015-08-26 09:46:50 PDT

Looks good to me. Unofficial r=me. Thanks for cleaning this part of the code.

Comment 3 WebKit Commit Bot 2015-08-26 10:34:06 PDT

Comment on attachment 259917 [details]
Patch

Clearing flags on attachment: 259917

Committed r188969: <http://trac.webkit.org/changeset/188969>

Comment 4 WebKit Commit Bot 2015-08-26 10:34:09 PDT

All reviewed patches have been landed.  Closing bug.