| Summary: | AX: Enable accessibility/aria-controls.html test for mac | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Nan Wang <n_wang> | ||||||
| Component: | Accessibility | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, jcraig, jdiggs, mario, n_wang, samuel_white, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=127908 | ||||||||
| Attachments: |
|
||||||||
|
Description
Nan Wang
2015-08-25 18:26:03 PDT
Created attachment 259910 [details]
patch
How come you're not using the string value in the test like the other platform That looks like a good check because it's able to validate that the element at that index is actually the right one (In reply to comment #2) > How come you're not using the string value in the test like the other > platform > That looks like a good check because it's able to validate that the element > at that index is actually the right one On Mac, the string value for the div is empty. Should I change the element type? That's probably because a div is being returned On Mac platform we should get the child of that object and check the string value I think Created attachment 259926 [details]
patch
Comment on attachment 259926 [details] patch Clearing flags on attachment: 259926 Committed r188947: <http://trac.webkit.org/changeset/188947> All reviewed patches have been landed. Closing bug. |