Bug 148458

Summary: AX: Enable accessibility/aria-controls.html test for mac
Product: WebKit Reporter: Nan Wang <n_wang>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, jcraig, jdiggs, mario, n_wang, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=127908
Attachments:
Description Flags
patch
none
patch none

Nan Wang
Reported 2015-08-25 18:26:03 PDT
The test is marked Skip in TestExpectation file.
Attachments
patch (7.41 KB, patch)
2015-08-25 18:31 PDT, Nan Wang 		no flags
DetailsFormatted DiffDiff
patch (7.47 KB, patch)
2015-08-25 22:23 PDT, Nan Wang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nan Wang
Comment 1 2015-08-25 18:31:41 PDT
Created attachment 259910 [details] patch
chris fleizach
Comment 2 2015-08-25 20:32:32 PDT
How come you're not using the string value in the test like the other platform That looks like a good check because it's able to validate that the element at that index is actually the right one
Nan Wang
Comment 3 2015-08-25 21:02:49 PDT
(In reply to comment #2) > How come you're not using the string value in the test like the other > platform > That looks like a good check because it's able to validate that the element > at that index is actually the right one On Mac, the string value for the div is empty. Should I change the element type?
chris fleizach
Comment 4 2015-08-25 22:01:38 PDT
That's probably because a div is being returned On Mac platform we should get the child of that object and check the string value I think
Nan Wang
Comment 5 2015-08-25 22:23:44 PDT
Created attachment 259926 [details] patch
WebKit Commit Bot
Comment 6 2015-08-25 23:50:01 PDT
Comment on attachment 259926 [details] patch Clearing flags on attachment: 259926 Committed r188947: <http://trac.webkit.org/changeset/188947>
WebKit Commit Bot
Comment 7 2015-08-25 23:50:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.