Summary: | Range.detach() / NodeIterator.detach() should be no-ops as per the latest DOM specification | ||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||||||||||||||||||||||||
Component: | DOM | Assignee: | Chris Dumez <cdumez> | ||||||||||||||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||||||||||||||
Severity: | Normal | CC: | ap, benjamin, buildbot, cgarcia, commit-queue, darin, dbates, kling, koivisto, rniwa, sam, webkit-bug-importer | ||||||||||||||||||||||||||||||
Priority: | P2 | Keywords: | InRadar, WebExposed | ||||||||||||||||||||||||||||||
Version: | Other | ||||||||||||||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||||||||||||||
Attachments: |
|
Description
Chris Dumez
2015-08-25 16:50:32 PDT
Range.detach is a no-op in Firefox since v15: - https://bugzilla.mozilla.org/show_bug.cgi?id=702948 Range.detach is a no-op in Chrome since April 2014: - https://src.chromium.org/viewvc/blink?revision=173010&view=revision NodeIterator.detach is a no-op in Firefox since v22: - https://bugzilla.mozilla.org/show_bug.cgi?id=823549 NodeIterator.detach is a no-op in Chrome since April 2014: - https://src.chromium.org/viewvc/blink?revision=172768&view=revision Created attachment 259927 [details]
Patch
Created attachment 259932 [details]
Patch
Created attachment 259948 [details]
Patch
Created attachment 259956 [details]
Patch
Created attachment 259957 [details]
Patch
Created attachment 259959 [details]
Patch
Created attachment 259961 [details]
Patch
Created attachment 259962 [details]
Patch
ping review? Comment on attachment 259962 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259962&action=review > Source/WebCore/dom/Range.cpp:1718 > + startContainer().formatForDebugger(s, FormatBufferSize); > + result.append(s); We should clean up this mess in a separate patch... Created attachment 260297 [details]
Patch
Created attachment 260299 [details]
Patch
Comment on attachment 260299 [details] Patch Rejecting attachment 260299 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 260299, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebKit2/ChangeLog contains OOPS!. Full output: http://webkit-queues.webkit.org/results/126997 Created attachment 260301 [details]
Patch
Comment on attachment 260301 [details] Patch Attachment 260301 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/127062 New failing tests: http/tests/w3c/dom/ranges/Range-compareBoundaryPoints.html http/tests/w3c/dom/ranges/Range-isPointInRange.html Created attachment 260304 [details]
Archive of layout-test-results from ews102 for mac-mavericks
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-mavericks Platform: Mac OS X 10.9.5
Comment on attachment 260301 [details] Patch Attachment 260301 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/127103 New failing tests: http/tests/w3c/dom/ranges/Range-compareBoundaryPoints.html http/tests/w3c/dom/ranges/Range-isPointInRange.html Created attachment 260306 [details]
Archive of layout-test-results from ews106 for mac-mavericks-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Created attachment 260309 [details]
Patch
Comment on attachment 260309 [details] Patch Clearing flags on attachment: 260309 Committed r189182: <http://trac.webkit.org/changeset/189182> All reviewed patches have been landed. Closing bug. |